Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.java > #12546

Re: help with plugin versions and maven-debian-helper

Show all headers | View raw

On Thu, Feb 09, 2023 at 11:07:14PM +0100, Emmanuel Bourg wrote:
> Le 2023-02-09 19:39, Joe Nahmias a écrit :
> 
> > Thanks for all your help. I think I managed to figure this out finally.
> > I've put my repo on salsa here:
> > https://salsa.debian.org/java-team/jackson-modules-java8
> > 
> > Anyone care to do a(n in-depth) review before I upload?
> 
> Great! Here is my review:
> 
> - Don't build the -java-doc package, that's useless

Um, why do you say it's useless?

> - The Maven wrapper should be removed (mwn* and .mvn/wrapper/*)

Yeah, I thought about that only after I did the repack...

> - I'd use the default gbp branch layout (master/upstream/pristine-tar)
>   instead of the DEP 14 layout (debian/latest). Most Java packages
>   follow the gbp layout and it's important all packages remain consistent.

ACK. That's an easy fix

> - Drop the +ds suffix

Why? Isn't that traditionally used to show a repack?

> - debian/changelog doesn't close an ITP bug

Yeah, I never opened one.

> - Why declaring a Provides field on virtual packages? That's unusual

Okay, I was thinking it would help discoverability, but I can certainly
drop it.

> The content of the binary package is perfect. Nice trick in debian/control
> to reuse the same description, I didn't know that was possible.

Thanks, I only learned of it a few months ago.

> Emmanuel Bourg

Much appreciated,
--Joe

Back to linux.debian.maint.java | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-08 05:50 +0100
  Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-08 09:00 +0100
    Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-09 00:10 +0100
      Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-09 00:30 +0100
        Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-09 08:40 +0100
          Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-09 19:40 +0100
            Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-09 23:10 +0100
              Re: help with plugin versions and maven-debian-helper Vladimir Petko <vladimir.petko@canonical.com> - 2023-02-09 23:20 +0100
                Re: help with plugin versions and maven-debian-helper Thorsten Glaser <t.glaser@tarent.de> - 2023-02-09 23:30 +0100
              Re: help with plugin versions and maven-debian-helper Thorsten Glaser <t.glaser@tarent.de> - 2023-02-09 23:20 +0100
              Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-10 02:00 +0100
                Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-10 13:00 +0100
                Re: help with plugin versions and maven-debian-helper Thorsten Glaser <t.glaser@tarent.de> - 2023-02-10 15:10 +0100
                Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-10 16:40 +0100

csiph-web