Groups > linux.debian.maint.java > #12546

Re: help with plugin versions and maven-debian-helper

Path	csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod
From	Joe Nahmias <joe@nahmias.net>
Newsgroups	linux.debian.maint.java
Subject	Re: help with plugin versions and maven-debian-helper
Date	Fri, 10 Feb 2023 02:00:01 +0100
Message-ID	<FXpVD-4JNE-13@gated-at.bofh.it> (permalink)
References	<FWKz7-4jkQ-1@gated-at.bofh.it> <FWNwZ-4lFC-11@gated-at.bofh.it> <FX1JD-4uTa-15@gated-at.bofh.it> <FX22Z-4uZH-3@gated-at.bofh.it> <FX9Hb-4A3w-3@gated-at.bofh.it> <FXjZU-4GiL-13@gated-at.bofh.it> <FXnh7-4Irm-5@gated-at.bofh.it>
X-Original-To	Emmanuel Bourg <ebourg@apache.org>
X-Mailbox-Line	From debian-java-request@lists.debian.org Fri Feb 10 00:51:35 2023
Old-Return-Path	<joe@nahmias.net>
X-Amavis-Spam-Status	No, score=-7.2 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5] autolearn=ham autolearn_force=no
Mail-Followup-To	Joe Nahmias <joe@nahmias.net>, Emmanuel Bourg <ebourg@apache.org>, debian-java@lists.debian.org
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
X-Mailing-List	<debian-java@lists.debian.org> archive/latest/23197
List-ID	<debian-java.lists.debian.org>
List-URL	<https://lists.debian.org/debian-java/>
List-Archive	https://lists.debian.org/msgid-search/Y+WU4l6eXpODsUVs@debian-BULLSEYE-live-builder-AMD64
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-java@lists.debian.org
X-Original-Date	Thu, 9 Feb 2023 19:50:42 -0500
X-Original-Message-ID	<Y+WU4l6eXpODsUVs@debian-BULLSEYE-live-builder-AMD64>
X-Original-References	<Y+Mpahbc3lJYhbr2@debian-BULLSEYE-live-builder-AMD64> <5727dc243076178631326e380aa5ac10@apache.org> <Y+QqVhimAvvNNbYh@nahmias.net> <Y+QvHsgCLpxiB732@nahmias.net> <f3c62d02a923dc03306cc75682a5fb5f@apache.org> <Y+U9yRSHnh4BaczB@debian-BULLSEYE-live-builder-AMD64> <775eae911ef06536b5f24424e4c91ae2@apache.org>
Xref	csiph.com linux.debian.maint.java:12546

Show key headers only | View raw

On Thu, Feb 09, 2023 at 11:07:14PM +0100, Emmanuel Bourg wrote:
> Le 2023-02-09 19:39, Joe Nahmias a écrit :
> 
> > Thanks for all your help. I think I managed to figure this out finally.
> > I've put my repo on salsa here:
> > https://salsa.debian.org/java-team/jackson-modules-java8
> > 
> > Anyone care to do a(n in-depth) review before I upload?
> 
> Great! Here is my review:
> 
> - Don't build the -java-doc package, that's useless

Um, why do you say it's useless?

> - The Maven wrapper should be removed (mwn* and .mvn/wrapper/*)

Yeah, I thought about that only after I did the repack...

> - I'd use the default gbp branch layout (master/upstream/pristine-tar)
>   instead of the DEP 14 layout (debian/latest). Most Java packages
>   follow the gbp layout and it's important all packages remain consistent.

ACK. That's an easy fix

> - Drop the +ds suffix

Why? Isn't that traditionally used to show a repack?

> - debian/changelog doesn't close an ITP bug

Yeah, I never opened one.

> - Why declaring a Provides field on virtual packages? That's unusual

Okay, I was thinking it would help discoverability, but I can certainly
drop it.

> The content of the binary package is perfect. Nice trick in debian/control
> to reuse the same description, I didn't know that was possible.

Thanks, I only learned of it a few months ago.

> Emmanuel Bourg

Much appreciated,
--Joe

Back to linux.debian.maint.java | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-08 05:50 +0100
  Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-08 09:00 +0100
    Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-09 00:10 +0100
      Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-09 00:30 +0100
        Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-09 08:40 +0100
          Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-09 19:40 +0100
            Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-09 23:10 +0100
              Re: help with plugin versions and maven-debian-helper Vladimir Petko <vladimir.petko@canonical.com> - 2023-02-09 23:20 +0100
                Re: help with plugin versions and maven-debian-helper Thorsten Glaser <t.glaser@tarent.de> - 2023-02-09 23:30 +0100
              Re: help with plugin versions and maven-debian-helper Thorsten Glaser <t.glaser@tarent.de> - 2023-02-09 23:20 +0100
              Re: help with plugin versions and maven-debian-helper Joe Nahmias <joe@nahmias.net> - 2023-02-10 02:00 +0100
                Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-10 13:00 +0100
                Re: help with plugin versions and maven-debian-helper Thorsten Glaser <t.glaser@tarent.de> - 2023-02-10 15:10 +0100
                Re: help with plugin versions and maven-debian-helper Emmanuel Bourg <ebourg@apache.org> - 2023-02-10 16:40 +0100

csiph-web