Groups > comp.os.os2.programmer.misc > #304

Re: Passing string pointers in a custom control-data structure == FAIL

From	"Rich Walsh" <spamyourself@127.0.0.1>
Message-ID	<brddYgxvE0gm-pn2-IEgQdK2mrYST@localhost> (permalink)
Newsgroups	comp.os.os2.programmer.misc
Subject	Re: Passing string pointers in a custom control-data structure == FAIL
References	(1 earlier) <slrnivpqbk.eou.abuse@news.pr.network> <mdq090pMZSKk-pn2-tZMpRGyxQxdM@localhost> <iu2igk$f0i$1@dont-email.me> <brddYgxvE0gm-pn2-RhP0cWKw5YCp@localhost> <11p86vVJT4Oe-pn2-yvY1LHo1Z3eu@slamain.slainc.com>
Date	2011-06-26 07:11 +0000
Organization	Unlimited download news at news.astraweb.com

Show all headers | View raw

On Sat, 25 Jun 2011 03:43:17 UTC, "Steven Levine" <steve53@nomail.earthlink.net> wrote:

> I do see some possible memory leaks from extra strudups, but these are
> not the cause of the corruption.

<OT> It may not have been the source of the corruption here, but a mishandled
strdup() was the primary cause of random crashes in Firefox from v3.0 until
the last FF 4.0 beta (when I discovered it).

The author used strdup(), then later appended a space to the string.  Since
the original string including the null was 16 bytes - and since libc allocates
in 8 or 16 byte chunks (I forget which) - that 17th byte corrupted whatever
happened to be next to it on the heap.  Had the string been a byte of two
longer or shorter, this ..um.. naive programmer's error would have had no
effect at all.

-- 
== == almost usable email address:  Rich AT E-vertise DOT Com == ==

Back to comp.os.os2.programmer.misc | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-17 23:08 -0500
  Re: Passing string pointers in a custom control-data structure == FAIL Marcel Müller <news.5.maazl@spamgourmet.com> - 2011-06-18 09:23 +0200
    Re: Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-18 06:05 -0500
  Re: Passing string pointers in a custom control-data structure == FAIL "A.D. Fundum" <what.ever@neverm.ind> - 2011-06-18 12:14 +0200
    Re: Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-18 06:03 -0500
  Re: Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-18 06:10 -0500
    Re: Passing string pointers in a custom control-data structure == FAIL Marcel Müller <news.5.maazl@spamgourmet.com> - 2011-06-20 09:55 +0200
      Re: Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-20 09:01 -0500
        Re: Passing string pointers in a custom control-data structure == FAIL "Steven Levine" <steve53@nomail.earthlink.net> - 2011-06-20 10:50 -0500
          Re: Passing string pointers in a custom control-data structure == FAIL Marcel Müller <news.5.maazl@spamgourmet.com> - 2011-06-21 08:23 +0200
          Re: Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-21 06:50 -0500
            Re: Passing string pointers in a custom control-data structure == FAIL "Steven Levine" <steve53@nomail.earthlink.net> - 2011-06-24 23:17 -0500
              Re: Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-26 06:50 -0500
          The actual program "Alex Taylor" <mail.me@reply.to.address> - 2011-06-21 06:59 -0500
            Re: The actual program "Steven Levine" <steve53@nomail.earthlink.net> - 2011-06-24 14:42 -0500
              Re: The actual program "Alex Taylor" <mail.me@reply.to.address> - 2011-06-26 06:48 -0500
        Re: Passing string pointers in a custom control-data structure == FAIL Marcel Müller <news.5.maazl@spamgourmet.com> - 2011-06-21 08:39 +0200
    Re: Passing string pointers in a custom control-data structure == FAIL Paul Ratcliffe <abuse@orac12.clara34.co56.uk78> - 2011-06-20 09:30 +0000
  Re: Passing string pointers in a custom control-data structure == FAIL Peter Flass <Peter_Flass@Yahoo.com> - 2011-06-18 08:08 -0400
  Re: Passing string pointers in a custom control-data structure == FAIL Paul Ratcliffe <abuse@orac12.clara34.co56.uk78> - 2011-06-18 18:07 +0000
    Re: Passing string pointers in a custom control-data structure == FAIL "Alex Taylor" <mail.me@reply.to.address> - 2011-06-20 09:01 -0500
      Re: Passing string pointers in a custom control-data structure == FAIL "Lars Erdmann" <lars.erdmann@arcor.de> - 2011-06-22 22:22 +0200
      Re: Passing string pointers in a custom control-data structure == FAIL Marty <net@comcast.martyamodeo> - 2011-06-24 10:45 -0700
        Re: Passing string pointers in a custom control-data structure == FAIL "Rich Walsh" <spamyourself@127.0.0.1> - 2011-06-25 03:04 +0000
          Re: Passing string pointers in a custom control-data structure == FAIL "Steven Levine" <steve53@nomail.earthlink.net> - 2011-06-24 22:43 -0500
            Re: Passing string pointers in a custom control-data structure == FAIL "Rich Walsh" <spamyourself@127.0.0.1> - 2011-06-26 07:11 +0000
  Re: Passing string pointers in a custom control-data structure == FAIL James Moe <jimoeDESPAM@sohnen-moe.com> - 2011-06-18 21:43 -0700

csiph-web