Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.programmer > #12625

Re: Strange Socket problem

Show all headers | View raw

On 1 mrt, 20:49, Knute Johnson <nos...@knutejohnson.com> wrote:
> I'm having a problem in some production code that I can't figure out.
> I'll post the complete actual code below.  This code is running in three
> places and has the same problem in two of them at the same time.  The
> other I'm not sure, it may be that the personnel operating it are
> restarting the program and so don't complain.  This piece of code is a
> simple client that connects via a Socket to a server.  The server
> supplies some data and the client reads that data and files it away.  It
> is supposed to restart itself if there is a connection failure or fault
> for whatever reason.  The problem is that at some random point in time
> the Socket disconnects, the code logs the disconnect but never restarts.
>   It does print the "SportsWinClient Disconnected" message but never
> executes the "fireconnectionEvent()" method after creating a new Socket.
>   It doesn't print any Exception message.  I'm not sure how it gets out
> of the try block without printing the "End of Stream" message or an
> exception message.
>
> The crazy part is that all night long when there is no activity from the
> server it times out and restarts with no problems.
>
> I'm hoping that somebody will see a fault in my code that could cause
> the failure.  It is not a compile problem so I left the formatting as it is.
>
> Thanks for looking.
>
> package com.knutejohnson.xyzcasinos.translux;
>
> import java.io.*;
> import java.net.*;
> import java.util.*;
>
> import com.knutejohnson.classes.*;
>
> import static com.knutejohnson.xyzcasinos.translux.Constants.*;
>
> public class SportsWinClient implements Runnable {
>      private final Thread thread;
>
>      private volatile boolean isConnected;
>      private volatile boolean runFlag = true;
>
>      private volatile Socket socket;
>
>      public SportsWinClient() {
>          thread = new Thread(this,"SportsWinClient");
>      }
>
>      public void start() {
>          thread.start();
>      }
>
>      public void run() {
> //        boolean serverFlag = true;
>
>          System.out.println("SportsWinClient: Started");
>          while (runFlag) {
> //            String serverAddress = serverFlag ? SPORTS_WIN_IP_PRIMARY :
> //             SPORTS_WIN_IP_SECONDARY;
>              try {
> //                socket = new Socket(serverAddress,SPORTS_WIN_PORT,
>                  socket = new Socket(SPORTS_WIN_IP,SPORTS_WIN_PORT,
>                   InetAddress.getByName(REMOTE_IP),0);
>                  socket.setKeepAlive(true);
>                  isConnected = true;
>
> ********* I know that the line below is not being executed **********
>
>                  fireConnectionEvent(ConnectionEvent.CONNECTED);
>                  socket.setSoTimeout(3600000);  // one hour timeout
>                  System.out.println("SportsWinClient: Connected");
>                  InputStream is = socket.getInputStream();
>                  InputStreamReader isr = new InputStreamReader(is);
>                  BufferedReader br = new BufferedReader(isr);
>
>                  String str;
>                  while ((str = br.readLine()) != null) {
>                      if (!str.matches("\\d+.*"))  // not a sports record
>                          continue;
>                      SportsBet sb = new SportsBet(str);
>                      SPORTS_BET_MAP.put(sb.betNumber,sb);
>                  }
>
>                  System.out.println("SportsWinClient: End of Stream");
>              } catch (IOException ioe) {
>                  System.out.println("SportsWinClient: " + ioe.toString());
>              } finally {
>                  isConnected = false;
>                  if (socket != null)
>                      try {
>                          socket.close();
>                      } catch (IOException ioe) {
>                          ioe.printStackTrace();
>                      }
>                  fireConnectionEvent(ConnectionEvent.DISCONNECTED);
> //                serverFlag = !serverFlag;
>
> *********** I know that the line below is being executed *************
>
>                  System.out.println("SportsWinClient: Disconnected");
>              }
>              // stop interrupts this thread so this will be bypassed on
> a stop
>              try {
>                  Thread.sleep(10000);
>              } catch (InterruptedException ie) { }
>          }
>          System.out.println("SportsWinClient: Stopping");
>      }
>
>      public void disconnect() {
>          if (isConnected())
>              if (socket != null)
>                  try {
>                      socket.close();
>                  } catch (IOException ioe) {
>                      ioe.printStackTrace();
>                  }
>      }
>
>      public void stop() {
>          runFlag = false;
>          thread.interrupt();
>          if (socket != null)
>              try {
>                  socket.close();
>              } catch (IOException ioe) {
>                  ioe.printStackTrace();
>              }
>      }
>
>      public boolean isConnected() {
>          return isConnected;
>      }
>
>      private final java.util.List<ConnectionListener> connectionListeners =
>       new ArrayList<ConnectionListener>();
>
>      public synchronized void addConnectionListener(ConnectionListener cl) {
>          connectionListeners.add(cl);
>      }
>
>      public synchronized void
> removeConnectionListener(ConnectionListener cl) {
>          connectionListeners.remove(cl);
>      }
>
>      private synchronized void fireConnectionEvent(int id) {
>          ConnectionEvent ce = new ConnectionEvent(this,id);
>
>          for (ConnectionListener listener : connectionListeners)
>              listener.connState(ce);
>      }
>
> }
>
> --
>
> Knute Johnson

Like Steven I would suggest you add Catch Throwable to log the
information about any unexpected happening and make sure that you get
it from the log when it actually occurs. It should give you a clear
indication what to look for to solve the issue.

Kind regards, Paka

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-01 11:49 -0800
  Re: Strange Socket problem Steven Simpson <ss@domain.invalid> - 2012-03-01 20:59 +0000
    Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-01 13:30 -0800
      Re: Strange Socket problem Steven Simpson <ss@domain.invalid> - 2012-03-01 22:54 +0000
        Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-01 16:32 -0800
          Re: Strange Socket problem Steven Simpson <ss@domain.invalid> - 2012-03-03 09:08 +0000
            Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-03 17:48 -0800
  Re: Strange Socket problem markspace <-@.> - 2012-03-01 14:08 -0800
    Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-01 16:48 -0800
      Re: Strange Socket problem markspace <-@.> - 2012-03-02 08:33 -0800
        Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-02 15:29 -0800
          Re: Strange Socket problem markspace <-@.> - 2012-03-03 09:33 -0800
            Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-03 17:55 -0800
              Re: Strange Socket problem markspace <-@.> - 2012-03-03 20:06 -0800
                Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-03 21:02 -0800
                Re: Strange Socket problem "John B. Matthews" <nospam@nospam.invalid> - 2012-03-05 00:00 -0500
                Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-05 09:44 -0800
  Re: Strange Socket problem Martin Gregorie <martin@address-in-sig.invalid> - 2012-03-01 22:15 +0000
    Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-01 16:43 -0800
      Re: Strange Socket problem Martin Gregorie <martin@address-in-sig.invalid> - 2012-03-03 02:01 +0000
  Reiteration: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-01 16:51 -0800
    Re: Reiteration: Strange Socket problem Martin Gregorie <martin@address-in-sig.invalid> - 2012-03-03 02:02 +0000
  Re: Strange Socket problem x <x@x.x> - 2012-03-02 21:18 +0100
    Re: Strange Socket problem Lew <noone@lewscanon.com> - 2012-03-02 15:06 -0800
      Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-02 15:38 -0800
        Re: Strange Socket problem Lew <noone@lewscanon.com> - 2012-03-02 16:00 -0800
          Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-02 17:18 -0800
            Re: Strange Socket problem Martin Gregorie <martin@address-in-sig.invalid> - 2012-03-03 02:13 +0000
              Re: Strange Socket problem Steven Simpson <ss@domain.invalid> - 2012-03-03 08:41 +0000
                Re: Strange Socket problem Martin Gregorie <martin@address-in-sig.invalid> - 2012-03-03 18:26 +0000
        Re: Strange Socket problem x <x@x.x> - 2012-03-03 11:32 +0100
          Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-03 17:59 -0800
          Re: Strange Socket problem Lew <noone@lewscanon.com> - 2012-03-03 23:21 -0800
      Re: Strange Socket problem x <x@x.x> - 2012-03-03 10:59 +0100
        Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-03 18:08 -0800
    Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-02 15:33 -0800
  Re: Strange Socket problem Paka Small <paka-en@tumia.org> - 2012-03-03 03:32 -0800
    Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-03 18:00 -0800
  Re: Strange Socket problem x <x@x.x> - 2012-03-03 12:45 +0100
    Re: Strange Socket problem Knute Johnson <nospam@knutejohnson.com> - 2012-03-03 18:02 -0800

csiph-web