Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #62942

Re: [PATCH v2] deb-pkg: generate correct build dependencies

Show all headers | View raw

On Wed, Jan 02, 2019 at 07:48:12PM +0000, Ben Hutchings wrote:
> On Wed, 2019-01-02 at 11:23 +0200, riku.voipio@linaro.org wrote:
> > From: Riku Voipio <riku.voipio@linaro.org>
> > 
> > bison/flex is now needed always for building for kconfig. Some build
> > dependencies depend on kernel configuration, enable them as needed:
> > 
> > - libelf-dev when UNWINDER_ORC is set
> > - libssl-dev for SYSTEM_TRUSTED_KEYRING
> > 
> > Since the libssl-dev is needed for extract_cert binary, denote with
> > :native to install the libssl-dev for the build machines
> > architecture,
> > rather than for the architecture of the kernel being built.
> > 
> > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> 
> Reviewed-by: Ben Hutchings <ben@decadent.org.uk>

Acked-by: maximilian attems <maks@stro.at>
 
> > ---
> > v2: commit message updated
> > ---
> >  scripts/package/mkdebian | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> > index edcad61fe3cd..c858abf4569e 100755
> > --- a/scripts/package/mkdebian
> > +++ b/scripts/package/mkdebian
> > @@ -134,6 +134,8 @@ fi
> >  
> >  mkdir -p debian/
> >  echo $debarch > debian/arch
> > +extra_build_depends=", $(if_enabled_echo UNWINDER_ORC libelf-dev)"
> > +extra_build_depends="$extra_build_depends, $(if_enabled_echo SYSTEM_TRUSTED_KEYRING libssl-dev:native)"
> >  
> >  # Generate a simple changelog template
> >  cat <<EOF > debian/changelog
> > @@ -170,7 +172,7 @@ Source: $sourcename
> >  Section: kernel
> >  Priority: optional
> >  Maintainer: $maintainer
> > -Build-Depends: bc, kmod, cpio
> > +Build-Depends: bc, kmod, cpio, bison, flex $extra_build_depends
> >  Homepage: http://www.kernel.org/
> >  
> >  Package: $packagename
> -- 
> Ben Hutchings
> Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
> 
> 

Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] deb-pkg: generate correct build dependencies riku.voipio@linaro.org - 2019-01-02 12:30 +0100
  Re: [PATCH v2] deb-pkg: generate correct build dependencies Ben Hutchings <ben@decadent.org.uk> - 2019-01-02 20:50 +0100
    Re: [PATCH v2] deb-pkg: generate correct build dependencies maximilian attems <maks@stro.at> - 2019-01-02 21:30 +0100
  Re: [PATCH v2] deb-pkg: generate correct build dependencies Masahiro Yamada <yamada.masahiro@socionext.com> - 2019-01-02 23:00 +0100
    Re: [PATCH v2] deb-pkg: generate correct build dependencies Masahiro Yamada <yamada.masahiro@socionext.com> - 2019-02-18 17:40 +0100
      Re: [PATCH v2] deb-pkg: generate correct build dependencies Masahiro Yamada <yamada.masahiro@socionext.com> - 2019-02-18 18:30 +0100
        Re: [PATCH v2] deb-pkg: generate correct build dependencies Ben Hutchings <ben@decadent.org.uk> - 2019-02-18 19:00 +0100
          Re: [PATCH v2] deb-pkg: generate correct build dependencies Ben Hutchings <ben@decadent.org.uk> - 2019-02-18 19:00 +0100
          Re: [PATCH v2] deb-pkg: generate correct build dependencies Masahiro Yamada <yamada.masahiro@socionext.com> - 2019-02-19 03:40 +0100
            Re: [PATCH v2] deb-pkg: generate correct build dependencies Masahiro Yamada <yamada.masahiro@socionext.com> - 2019-02-20 05:10 +0100

csiph-web