Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #882961

Bug#890950: initramfs-tools: Resuming from hibernated swapfile fails

Cross-posted to 2 groups.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Control: tag -1 moreinfo

On Tue, 2018-02-20 at 22:11 +0000, Mario.Limonciello@dell.com wrote:
> Package: initramfs-tools
> Version: 0.130ubuntu2
> Severity: important
> 
> Dear Maintainer,
> 
> I've found that resuming from a hibernated swapfile using the kernel hibernate
> implementation fails.  This is due to some assumptions made in initramfs-tools:
> 
> 1) It requires that uswpswp is installed (to provide /bin/resume)[...]

No, it runs /bin/resume which is installed by klibc-utils.  (uswsusp
installs its resume implementation as /sbin/resume.  That's what the
comment is about.)

> 2) It doesn't properly detect offsets

So far as I can see, the kernel has never really supported an offset
being passed through /sys/power/resume.  However:

1. The kernel parses the resume_offset parameter, and uses that for
every resume request.
2. The implementation of /sys/power/resume is not very strict, and
ignores the trailing ":offset".

This second feature was briefly broken between Linux 4.1-rc1 and 4.1-
rc3, but otherwise still seems to work.  So I don't see what your
change is fixing.

However I do think that either:

1. The kernel should add real support for setting the resume offset
after boot.
2. klibc should stop writing the unused offset parameter.

Ben.

-- 
Ben Hutchings
[W]e found...that it wasn't as easy to get programs right as we had
thought. ... I realized that a large part of my life from then on was
going to be spent in finding mistakes in my own programs. - Maurice
Wilkes, 1949

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#890950: initramfs-tools: Resuming from hibernated swapfile fails <Mario.Limonciello@dell.com> - 2018-02-20 23:30 +0100
  Bug#890950: initramfs-tools: Resuming from hibernated swapfile fails Ben Hutchings <ben@decadent.org.uk> - 2018-02-21 19:00 +0100
    Bug#890950: initramfs-tools: Resuming from hibernated swapfile fails <Mario.Limonciello@dell.com> - 2018-02-21 22:30 +0100
  Bug#890950:  <Mario.Limonciello@dell.com> - 2018-02-22 05:00 +0100
  Bug#890950: Info received (Bug#890950: initramfs-tools: Resuming from hibernated swapfile fails) <Mario.Limonciello@dell.com> - 2018-02-28 23:10 +0100

csiph-web