Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #854992

Bug#877869: kirkwood-t5325.dts fixes for poweroff and sound device detection issues on HP T5325

Cross-posted to 2 groups.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Package: linux-image-4.9.0-3-marvell
Version: 4.9.30-2+deb9u5

When the kirkwood-t5325.dtb included in the package is used on HP T5325,
the poweroff command fails to power off the device (indicated by the
front blue light not turning off). It does however brings the device to
near power off ( I have seen a kernel panic at the end that can be seen
if a hardware serial connection is used). Also, with the same dtb, sound
device does not get detected. dmesg output contains the following:

[   10.861482] OF: /sound/simple-audio-card,cpu: arguments longer than
property
[   10.861492] asoc-simple-card sound: parse error -22
[   10.861508] asoc-simple-card: probe of sound failed with error -22

Fix:

Both problems could be corrected by fixing the dtb. "bodhi" at
https://forum.doozan.com possibly with the help of other forum members
had fixed and tested the corrections. Thanks go to him and those who
supported him!

If ever needed, package "bodhi" maintains can be found at
https://forum.doozan.com/read.php?2,12096 and the download contains a
patch file showing his modifications.

I myself tested the changes needed to fix the poweroff problem and the
sound device detection issue by getting the upstream kernel source,
changing two lines and compiling the kirkwood-t5325.dts. Please find the
attached working dtb and dts. The two fixes needed are as follows:

--- linux-master/arch/arm/boot/dts/kirkwood-t5325.dts    2017-10-05
01:16:05.000000000 +0100
+++ linux-master-fixed/arch/arm/boot/dts/kirkwood-t5325.dts   
2017-10-06 13:59:19.834377641 +0100
@@ -174,7 +174,7 @@
         compatible = "gpio-poweroff";
         pinctrl-0 = <&pmx_power_off>;
         pinctrl-names = "default";
-        gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+        gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>;
     };
 
     sound {
@@ -195,7 +195,7 @@
         simple-audio-card,mclk-fs = <256>;
 
         simple-audio-card,cpu {
-            sound-dai = <&audio>;
+            sound-dai = <&audio 0>;
         };
 
         simple-audio-card,codec {

I haven't submitted the changes to upstream. Appreciate if you release
the package with a corrected kirkwood-t5325.dtb.

Kamal

Back to linux.debian.bugs.dist | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Bug#877869: kirkwood-t5325.dts fixes for poweroff and sound device detection issues on HP T5325 Kamal Wickramanayake <kamal@swview.org> - 2017-10-06 15:30 +0200
  Bug#877869: Console output showing the poweroff issue Kamal Wickramanayake <kamal@swview.org> - 2017-10-07 21:20 +0200

csiph-web