Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

From	Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()
Date	2017-09-30 11:30 +0200
Message-ID	<uvmfU-2fB-17@gated-at.bofh.it> (permalink)
References	<uvmfU-2fB-19@gated-at.bofh.it> <uvmfU-2fB-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote:
> Similar to __down_write_killable(), and read killable primitive.
> 
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> ---
>  arch/s390/include/asm/rwsem.h |   18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/include/asm/rwsem.h b/arch/s390/include/asm/rwsem.h

FWIW, while looking into this patch I realized that we never optimized our
rwsem primitives to make use of new atomic instructions.

The generic rwsem header file however does, since it uses atomic ops which
we did optimize. Even when compiling for old machines the generic version
generates better code. Therefore I will remove the 15 years old s390
implementation and switch to the generic version instead.

The same might be true for alpha and ia64...

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable() Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-09-30 11:30 +0200
  Re: [PATCH REBASED 3/6] s390: Add __down_read_killable() Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-09-30 12:40 +0200
  Re: [PATCH REBASED 3/6] s390: Add __down_read_killable() Martin Schwidefsky <schwidefsky@de.ibm.com> - 2017-09-30 12:40 +0200
    Re: [PATCH REBASED 3/6] s390: Add __down_read_killable() Martin Schwidefsky <schwidefsky@de.ibm.com> - 2017-09-30 12:50 +0200

csiph-web