[PATCH] RDMA/hns: return 0 rather than return a garbage status value

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] RDMA/hns: return 0 rather than return a garbage status value
Date	2017-09-29 22:20 +0200
Message-ID	<uv9Vo-2wp-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
value in ret is being returned by function hns_roce_v2_query_qp.
Fix this by setting ret to 0 for this specific return condition.

Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 4870b51caab9..791dae72e775 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
 
 	if (hr_qp->state == IB_QPS_RESET) {
 		qp_attr->qp_state = IB_QPS_RESET;
+		ret = 0;
 		goto done;
 	}
 
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] RDMA/hns: return 0 rather than return a garbage status value Colin King <colin.king@canonical.com> - 2017-09-29 22:20 +0200
  Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status  value "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-30 09:20 +0200

csiph-web