Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740450

Re: [PATCH v2] Asus WMI : Add lightbar led support

Show all headers | View raw

On Sat, Sep 23, 2017 at 06:23:37PM +0200, Maxime Bellengé wrote:

Hi Maxime,

Thanks for the update. The patch has been applied and is queued for
testing.

In the future, please take note of the following comments - which I have
addressed in the patch.

The commit subject format:

platform/x86: <driver>: Subject

Whenever submitting to the Linux kernel, please take note of the format
used in previous (especially recent) commits to the same and adjacent files.

> Some asus laptops (ROG series for example) are provided
> with a lightbar behind the monitor.
> This patch make possible to switch it on and off.
> This lightbar works exactly as any other led.

Wrap at 72 characters or so in paragraph form.

> 
> V2 : fix whitespaces and typo

Patch revision history goes below the --- line below (see the submitting
patches documentation for details). This ensures it is automatically
dropped during the patch application process and avoids the requirement
for manual edits by the maintainers.

> 
> Signed-off-by: Maxime Bellengé <maxime.bellenge@gmail.com>
> ---
>  drivers/platform/x86/asus-wmi.c | 63 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
...
> +static void lightbar_led_update(struct work_struct *work)
> +{
> +	int ctrl_param;
> +	struct asus_wmi *asus;

Declare variables in descending order of line length.

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] Asus WMI : Add lightbar led support Maxime Bellengé <maxime.bellenge@gmail.com> - 2017-09-23 18:30 +0200
  Re: [PATCH v2] Asus WMI : Add lightbar led support Darren Hart <dvhart@infradead.org> - 2017-09-27 09:30 +0200

csiph-web