Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741667

Re: [RFC 2/3] module: Ignore delete_id parameter

Show all headers | View raw

On 09/28/2017 03:02 AM, Greg Kroah-Hartman wrote:
> On Wed, Sep 27, 2017 at 04:40:21PM -0400, Jon Derrick wrote:
>> The PCI driver delete_id parameter is handled in each individual driver
>> registration callback.
>>
>> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
>> ---
>>  kernel/module.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/kernel/module.c b/kernel/module.c
>> index de66ec8..2b2dccf 100644
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -3620,6 +3620,13 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,
>>  		return 0;
>>  	}
>>  
>> +	/*
>> +	 * Ignore driver delete list arguments. They are handled by driver
>> +	 * registration callbacks
>> +	 */
>> +	if (strcmp(param, "delete_id") == 0)
>> +		return 0;
> 
> Why?  This is only for the PCI core as you have defined it in this
> patchset, but you just broke this module id for all other kernel modules
> in the system :(
> 
> If you want to do this, you need to provide this feature for _all_
> kernel drivers...
> 
> thanks,
> 
> greg k-h
> 
Yes I'm not particularly happy about this one either. I will make this
more robust if the blacklisting idea is sound.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC 0/3] Introduce PCI device blacklisting Jon Derrick <jonathan.derrick@intel.com> - 2017-09-27 22:50 +0200
  [RFC 1/3] PCI: pci-driver: Introduce pci device delete list Jon Derrick <jonathan.derrick@intel.com> - 2017-09-27 22:50 +0200
    Re: [RFC 1/3] PCI: pci-driver: Introduce pci device delete list Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-28 11:10 +0200
      Re: [RFC 1/3] PCI: pci-driver: Introduce pci device delete list Dan Williams <dan.j.williams@intel.com> - 2017-09-28 18:00 +0200
      Re: [RFC 1/3] PCI: pci-driver: Introduce pci device delete list Jon Derrick <jonathan.derrick@intel.com> - 2017-09-28 18:00 +0200
  [RFC 2/3] module: Ignore delete_id parameter Jon Derrick <jonathan.derrick@intel.com> - 2017-09-27 22:50 +0200
    Re: [RFC 2/3] module: Ignore delete_id parameter Dan Williams <dan.j.williams@intel.com> - 2017-09-28 08:10 +0200
      Re: [RFC 2/3] module: Ignore delete_id parameter Jon Derrick <jonathan.derrick@intel.com> - 2017-09-28 18:00 +0200
    Re: [RFC 2/3] module: Ignore delete_id parameter Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-28 11:10 +0200
      Re: [RFC 2/3] module: Ignore delete_id parameter Jon Derrick <jonathan.derrick@intel.com> - 2017-09-28 18:00 +0200

csiph-web