Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1738219

Re: [PATCH 0/4] iio: light: vl6180: Several fixes and enhancements

Show all headers | View raw

On Tue, 19 Sep 2017 05:11:40 +0200
Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:

> Currently, the vl6180 driver reports bogus in_illuminance_scale values
> when the integration time or hardware gain are changed from its default
> value, i.e. it always reports a fixed value.
> 
> To avoid readback of the register values in case integration time, gain
> or scale is queried, save the register values. Use the saved values
> to report the correct scale value.

Hmm. I think unfortunately that this set is too large and invasive
to send as a fix.  Hence once the little corners are tidied up I'll
take it via the slow path ready for the next merge window.

Thanks,

Jonathan

> 
> Stefan Brüns (4):
>   iio: light: vl6180: Move range check to integration time setter,
>     cleanup
>   iio: light: vl6180: Avoid readback of integration time register
>   iio: light: vl6180: Cleanup als_gain lookup, avoid register readback
>   iio: light: vl6180: Correct ALS scale for non-default gain/integration
>     time
> 
>  drivers/iio/light/vl6180.c | 125 +++++++++++++++++++++++++--------------------
>  1 file changed, 69 insertions(+), 56 deletions(-)
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] iio: light: vl6180: Several fixes and enhancements Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-09-19 05:20 +0200
  [PATCH 3/4] iio: light: vl6180: Cleanup als_gain lookup, avoid register readback Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-09-19 05:20 +0200
    Re: [PATCH 3/4] iio: light: vl6180: Cleanup als_gain lookup, avoid  register readback Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2017-09-19 08:20 +0200
  [PATCH 2/4] iio: light: vl6180: Avoid readback of integration time register Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-09-19 05:20 +0200
    Re: [PATCH 2/4] iio: light: vl6180: Avoid readback of integration  time register Jonathan Cameron <jic23@kernel.org> - 2017-09-24 17:40 +0200
  [PATCH 4/4] iio: light: vl6180: Correct ALS scale for non-default gain/integration time Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-09-19 05:20 +0200
  Re: [PATCH 0/4] iio: light: vl6180: Several fixes and enhancements Jonathan Cameron <jic23@kernel.org> - 2017-09-24 17:50 +0200

csiph-web