Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739920

Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a state

Show all headers | View raw

On Fri, Sep 22, 2017 at 09:57:22AM -0700, Florian Fainelli wrote:
> On 09/22/2017 06:20 AM, Charles Keepax wrote:
> > On Fri, Sep 22, 2017 at 01:55:22PM +0200, Linus Walleij wrote:
> >> On Thu, Sep 21, 2017 at 3:04 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> > I guess in our case we didn't really consider the restore aspect
> > because we essentially get that for free from regmap. Regmap
> > cache's all our register state and provides a mechanism to sync
> > that back to the hardware, so we simply invoke that on resume and
> > all our GPIO/pinctrl state is restored.
> 
> As you may see, the problem in my case is that the hardware has only onw
> pinctrl state: "default", and it loses its hardware register contents,
> and because of early check in pinctrl_select_state(), we do nothing (the
> state has not changed per-se), so we are left with SW thinking we
> applied the "default" state again, while in fact we did not.
> 

That is exactly the situation we have on the CODECs when they go
into runtime suspend, power is removed, and everything is back at
defaults when we resume. Just in our case we re-apply the state
as part of the CODEC resume using a regmap sync.

> The approach taken here was to move this to the core pinctrl code
> because this is not something a pinctrl consumer should be aware of,
> when it calls pinctrl_select_state(), it should do what it asked for.
> 

Apologies if I have missed something here, but does the consumer
not still to some extent need to be aware with this solution
since it needs to re-request the pin state in resume?

I think that is really my only reservation here, is it feels
like this should be something that is purely implemented on the
provider, and be invisible to the consumer, and I am not clear
this is.

> I also decided to make this a per-provider property as opposed to a
> per-group property because chances are that the state retention is on a
> per-controller basis, and not per-bank/group, although I may be wrong.
> 

It seems quite likely that this property would mostly be
per-provider to me as well.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] pinctrl: Allow a device to indicate when to force a state Florian Fainelli <f.fainelli@gmail.com> - 2017-09-21 03:10 +0200
  Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a state Linus Walleij <linus.walleij@linaro.org> - 2017-09-22 14:00 +0200
    Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Charles Keepax <ckeepax@opensource.cirrus.com> - 2017-09-22 15:30 +0200
      Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a state Linus Walleij <linus.walleij@linaro.org> - 2017-09-22 16:00 +0200
        Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Florian Fainelli <f.fainelli@gmail.com> - 2017-09-25 21:20 +0200
      Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Florian Fainelli <f.fainelli@gmail.com> - 2017-09-22 19:00 +0200
        Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Charles Keepax <ckeepax@opensource.cirrus.com> - 2017-09-26 16:20 +0200
          Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Florian Fainelli <f.fainelli@gmail.com> - 2017-09-26 20:00 +0200
            Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Charles Keepax <ckeepax@opensource.cirrus.com> - 2017-09-27 10:50 +0200
  Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Charles Keepax <ckeepax@opensource.cirrus.com> - 2017-09-22 14:50 +0200
    Re: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a  state Florian Fainelli <f.fainelli@gmail.com> - 2017-09-22 18:50 +0200

csiph-web