Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()

From	Eric Biggers <ebiggers3@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()
Date	2017-09-21 22:40 +0200
Message-ID	<usgql-5CD-5@gated-at.bofh.it> (permalink)
References	<ur97A-1vB-27@gated-at.bofh.it> <ursWB-7h8-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 19, 2017 at 04:46:08PM +0100, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
> 
> > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link()
> > were to fail, we would leak a reference to the 'struct cred'.  Currently
> > this can only happen if alloc_key() fails to to allocate memory.  But it
> > still should be fixed, as it is a more severe bug waiting to happen.
> 
> It might be better to combine request_key_auth_destroy() and the error path
> that you're altering in request_key_auth_new() by pulling it into a separate
> function.
> 
> David

Agreed, I'll do that.

Eric

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KEYS: fix cred refcount leak in request_key_auth_new() Eric Biggers <ebiggers3@gmail.com> - 2017-09-18 20:40 +0200
  Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new() David Howells <dhowells@redhat.com> - 2017-09-19 17:50 +0200
    Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new() Eric Biggers <ebiggers3@gmail.com> - 2017-09-21 22:40 +0200

csiph-web