Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736770
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header |
| Date | 2017-09-21 17:30 +0200 |
| Message-ID | <usbAl-2Ne-1@gated-at.bofh.it> (permalink) |
| References | <urHsB-8f3-7@gated-at.bofh.it> <urHsB-8f3-15@gated-at.bofh.it> <usbqG-2Ji-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Sep 21, 2017 at 05:18:42PM +0200, Jiri Olsa wrote:
> On Wed, Sep 20, 2017 at 11:12:32PM +0800, Jin Yao wrote:
>
> SNIP
>
> > @@ -2647,11 +2681,22 @@ int perf_file_header__read(struct perf_file_header *header,
> >
> > if (header->size != sizeof(*header)) {
> > /* Support the previous format */
> > - if (header->size == offsetof(typeof(*header), adds_features))
> > + if (header->size == offsetof(typeof(*header), adds_features)) {
> > bitmap_zero(header->adds_features, HEADER_FEAT_BITS);
> > - else
> > + header->first_sample_time = 0;
> > + header->last_sample_time = 0;
> > + format_feature = false;
> > + format_time = false;
> > + } else if (header->size == offsetof(typeof(*header),
> > + first_sample_time)) {
> > + header->first_sample_time = 0;
> > + header->last_sample_time = 0;
> > + format_time = false;
> > + } else
>
> ok, disregard my previou comment.. I should have read the full patch first ;-)
still using the feature looks better to me.. I think we could
add some generic TLV data feature for cases like this
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 0/6] perf report/script: Support percent and multiple range in --time option Jin Yao <yao.jin@linux.intel.com> - 2017-09-20 09:20 +0200
[PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header Jin Yao <yao.jin@linux.intel.com> - 2017-09-20 09:20 +0200
Re: [PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header Jiri Olsa <jolsa@redhat.com> - 2017-09-21 17:20 +0200
Re: [PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header Jiri Olsa <jolsa@redhat.com> - 2017-09-21 17:20 +0200
Re: [PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header Jiri Olsa <jolsa@redhat.com> - 2017-09-21 17:30 +0200
Re: [PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header "Jin, Yao" <yao.jin@linux.intel.com> - 2017-09-22 02:50 +0200
[PATCH v1 6/6] perf script: support time percent and multiple time ranges Jin Yao <yao.jin@linux.intel.com> - 2017-09-20 09:20 +0200
[PATCH v1 2/6] perf Documentation: Update perf.data-file-format.txt Jin Yao <yao.jin@linux.intel.com> - 2017-09-20 09:20 +0200
csiph-web