Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737909

Re: [PATCH 3/4] extable: Enable RCU if it is not watching in kernel_text_address()

Show all headers | View raw

On Fri, Sep 22, 2017 at 06:15:46PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> 
> If kernel_text_address() is called when RCU is not watching, it can cause an
> RCU bug because is_module_text_address() and the is_kprobe_*insn_slot()
> functions require the use of RCU.

is_bpf_text_address() also requires RCU.

> Only enable RCU if it is not currently watching before it calls
> is_module_text_address(). The use of rcu_nmi_enter() is used to enable RCU
> because kernel_text_address() can happen pretty much anywhere (like an NMI),
> and even from within an NMI. It is called via save_stack_trace() that can be
> called by any WARN() or tracing function, which can happen while RCU is not
> watching (for example, going to or coming from idle, or during CPU take down
> or bring up).
> 
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: stable@vger.kernel.org
> Fixes: 0be964be0 ("module: Sanitize RCU usage and locking")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
>  kernel/extable.c | 35 ++++++++++++++++++++++++++++++-----
>  1 file changed, 30 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/extable.c b/kernel/extable.c
> index a7024a494faf..89c4668376a6 100644
> --- a/kernel/extable.c
> +++ b/kernel/extable.c
> @@ -119,17 +119,42 @@ int __kernel_text_address(unsigned long addr)
>  
>  int kernel_text_address(unsigned long addr)
>  {
> +	bool no_rcu;
> +	int ret = 1;
> +
>  	if (core_kernel_text(addr))
>  		return 1;
> +
> +	/*
> +	 * If a stack dump happens while RCU is not watching, then
> +	 * RCU needs to be notified that it requires to start
> +	 * watching again. This can happen either by tracing that
> +	 * triggers a stack trace, or a WARN() that happens during
> +	 * coming back from idle, or cpu on or offlining.
> +	 *
> +	 * is_module_text_address() as well as the kprobe slots
> +	 * require RCU to be watching.

Ditto here.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] rcu/tracing/extable: Fix stack dump when RCU is not watching Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 00:20 +0200
  [PATCH 1/4] rcu: Allow for page faults in NMI handlers Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 00:20 +0200
  [PATCH 4/4] tracing: Remove RCU work arounds from stack tracer Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 00:20 +0200
    Re: [PATCH 4/4] tracing: Remove RCU work arounds from stack tracer "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-23 01:00 +0200
      Re: [PATCH 4/4] tracing: Remove RCU work arounds from stack tracer Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 03:30 +0200
        Re: [PATCH 4/4] tracing: Remove RCU work arounds from stack tracer "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-23 08:10 +0200
          Re: [PATCH 4/4] tracing: Remove RCU work arounds from stack tracer Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 13:30 +0200
            Re: [PATCH 4/4] tracing: Remove RCU work arounds from stack tracer "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-23 19:20 +0200
  [PATCH 3/4] extable: Enable RCU if it is not watching in kernel_text_address() Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 00:20 +0200
    Re: [PATCH 3/4] extable: Enable RCU if it is not watching in  kernel_text_address() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-23 00:40 +0200
      [PATCH 3/4 v2] extable: Enable RCU if it is not watching in  kernel_text_address() Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 03:20 +0200
    Re: [PATCH 3/4] extable: Enable RCU if it is not watching in  kernel_text_address() "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-23 00:50 +0200
      Re: [PATCH 3/4] extable: Enable RCU if it is not watching in  kernel_text_address() Steven Rostedt <rostedt@goodmis.org> - 2017-09-23 03:10 +0200

csiph-web