Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735133
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr |
| Date | 2017-09-19 20:00 +0200 |
| Message-ID | <uruYr-8tS-9@gated-at.bofh.it> (permalink) |
| References | <urtfX-7CA-3@gated-at.bofh.it> <urtfY-7CA-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/19/2017 08:56 AM, Vivien Didelot wrote: > DSA overrides the master's ethtool ops so that we can inject its CPU > port's statistics. Because of that, we need to setup the ethtool ops > after the master's dsa_ptr pointer has been assigned, not before. Yes, good point, technically this is a bugfix, but since we have changed this quite often and the race is tiny, I am not positive we could a) trigger this in real life, and b) provide a proper Fixes tag. > > This patch setups the ethtool ops after dsa_ptr is assigned, and > restores them before it gets cleared. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-19 18:10 +0200 Re: [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr Florian Fainelli <f.fainelli@gmail.com> - 2017-09-19 20:00 +0200
csiph-web