Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1735751

Re: rsi: fix a dereference on adapter before it has been null checked

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: rsi: fix a dereference on adapter before it has been null checked
Date 2017-09-20 14:50 +0200
Message-ID <urMBX-354-3@gated-at.bofh.it> (permalink)
References <untoe-qu-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Colin Ian King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment of dev is dereferencing adapter before adapter has
> been null checked, potentially leading to a null pointer dereference.
> Fix this by simply moving the assignment of dev to a later point
> after the sanity null check of adapter.
> 
> Detected by CoverityScan CID#1398383 ("Dereference before null check")
> 
> Fixes: dad0d04fa7ba ("rsi: Add RS9113 wireless driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied to wireless-drivers-next.git, thanks.

6508497cbdc7 rsi: fix a dereference on adapter before it has been null checked

-- 
https://patchwork.kernel.org/patch/9944509/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: rsi: fix a dereference on adapter before it has been null checked Kalle Valo <kvalo@codeaurora.org> - 2017-09-20 14:50 +0200

csiph-web