Re: [PATCH v5] blktrace: Fix potentail deadlock between delete & sysfs ops

From	Bart Van Assche <Bart.VanAssche@wdc.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] blktrace: Fix potentail deadlock between delete & sysfs ops
Date	2017-09-18 18:40 +0200
Message-ID	<ur7fs-fa-9@gated-at.bofh.it> (permalink)
References	<uqxEZ-1Og-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2017-09-16 at 19:37 -0700, Waiman Long wrote:
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 339e737..330b572 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -448,7 +448,7 @@ struct block_device {
>  
>  	/* The counter of freeze processes */
>  	int			bd_fsfreeze_count;
> -	/* Mutex for freeze */
> +	/* Mutex for freeze and blktrace */
>  	struct mutex		bd_fsfreeze_mutex;
>  } __randomize_layout;

This patch changes the meaning of bd_fsfreeze_mutex significantly. Please rename
that mutex such that its name matches its new role.

Thanks,

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] blktrace: Fix potentail deadlock between delete & sysfs ops Waiman Long <longman@redhat.com> - 2017-09-17 04:40 +0200
  Re: [PATCH v5] blktrace: Fix potentail deadlock between delete &  sysfs ops Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-09-18 18:40 +0200

csiph-web