Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1734067
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm |
| Date | 2017-09-18 13:50 +0200 |
| Message-ID | <ur2IO-5LK-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
From: Colin Ian King <colin.king@canonical.com> Pointer tcm is being initialized and is never read, it is only being used to determine the size of struct tcmsg. Clean this up by removing variable tcm and explicitly using the sizeof struct tcmsg rather than *tcm. Cleans up clang warning: warning: Value stored to 'tcm' during its initialization is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> --- net/sched/sch_api.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index c6deb74e3d2f..aa82116ed10c 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1500,7 +1500,6 @@ static int tc_dump_qdisc(struct sk_buff *skb, struct netlink_callback *cb) int s_idx, s_q_idx; struct net_device *dev; const struct nlmsghdr *nlh = cb->nlh; - struct tcmsg *tcm = nlmsg_data(nlh); struct nlattr *tca[TCA_MAX + 1]; int err; @@ -1510,7 +1509,7 @@ static int tc_dump_qdisc(struct sk_buff *skb, struct netlink_callback *cb) idx = 0; ASSERT_RTNL(); - err = nlmsg_parse(nlh, sizeof(*tcm), tca, TCA_MAX, NULL, NULL); + err = nlmsg_parse(nlh, sizeof(struct tcmsg), tca, TCA_MAX, NULL, NULL); if (err < 0) return err; -- 2.14.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm Colin King <colin.king@canonical.com> - 2017-09-18 13:50 +0200
RE: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm David Laight <David.Laight@ACULAB.COM> - 2017-09-18 14:20 +0200
Re: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm Eric Dumazet <eric.dumazet@gmail.com> - 2017-09-18 17:10 +0200
RE: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm David Laight <David.Laight@ACULAB.COM> - 2017-09-18 17:20 +0200
Re: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm David Miller <davem@davemloft.net> - 2017-09-19 02:00 +0200
csiph-web