Groups > linux.kernel > #1732021

RE: [Intel-wired-lan] [PATCH] igb: check memory allocation failure

From	"Brown, Aaron F" <aaron.f.brown@intel.com>
Newsgroups	linux.kernel
Subject	RE: [Intel-wired-lan] [PATCH] igb: check memory allocation failure
Date	2017-09-14 04:30 +0200
Message-ID	<ups4F-7ky-3@gated-at.bofh.it> (permalink)
References	<uiZyq-40C-9@gated-at.bofh.it> <ujeQN-5Zx-1@gated-at.bofh.it> <ujvRD-8lV-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf
> Of Christophe JAILLET
> Sent: Monday, August 28, 2017 10:13 AM
> To: Waskiewicz Jr, Peter <peter.waskiewicz.jr@intel.com>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@intel.com>
> Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; intel-wired-
> lan@lists.osuosl.org; linux-kernel@vger.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure
> 
> Le 28/08/2017 à 01:09, Waskiewicz Jr, Peter a écrit :
> > On 8/27/17 2:42 AM, Christophe JAILLET wrote:
> >> Check memory allocation failures and return -ENOMEM in such cases, as
> >> already done for other memory allocations in this function.
> >>
> >> This avoids NULL pointers dereference.
> >>
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >> ---
> >>    drivers/net/ethernet/intel/igb/igb_main.c | 2 ++
> >>    1 file changed, 2 insertions(+)
> >>

This seems to be fine from a "it does not break in testing" perspective, so...

Tested-by: Aaron Brown <aaron.f.brown@intel.com

> > -PJ
> >
> Hi,
> 
> in fact, there is no leak because the only caller of 'igb_sw_init()'
> (i.e. 'igb_probe()'), already frees these resources in case of error,
> see [1]
> 
> These resources are also freed  in 'igb_remove()'.
> 
> Best reagrds,
> CJ
> 
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-
> next.git/tree/drivers/net/ethernet/intel/igb/igb_main.c#n2775

But is PJ's comment saying that it is not really necessary?  If so I tend to lean towards the don't touch it if it's not broken perspective.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

RE: [Intel-wired-lan] [PATCH] igb: check memory allocation failure "Brown, Aaron F" <aaron.f.brown@intel.com> - 2017-09-14 04:30 +0200
  Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure "Waskiewicz Jr, Peter" <peter.waskiewicz.jr@intel.com> - 2017-09-14 16:50 +0200

csiph-web