Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

From	Hoegeun Kwon <hoegeun.kwon@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits
Date	2017-09-13 11:30 +0200
Message-ID	<upc9B-5vh-25@gated-at.bofh.it> (permalink)
References	(1 earlier) <unkEi-2Qx-27@gated-at.bofh.it> <unkEi-2Qx-25@gated-at.bofh.it> <uotmc-15R-39@gated-at.bofh.it> <up5KT-1mw-13@gated-at.bofh.it> <upbZV-5r0-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/13/2017 06:11 PM, Sylwester Nawrocki wrote:
> Hi Hoegeun,
>
> On 09/13/2017 04:33 AM, Hoegeun Kwon wrote:
>>>> @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq,
>>>> void *priv)
>>>>       static const struct of_device_id exynos_gsc_match[] = {
>>>>         {
>>>> -        .compatible = "samsung,exynos5-gsc",
>>>> -        .data = &gsc_v_100_drvdata,
>>> Can you keep the "samsung,exynos5-gsc" entry with the gsc_v_5250_variant
>>> data, so that it can work with "samsung,exynos5-gsc" compatible in DT
>>> on both exynos5250 and exynos5420 SoCs?
>>>
>> Thank you for your question.
>>
>> Exynos 5250 and 5420 have different hardware rotation limits.
>> Exynos 5250 is '.real_rot_en_w/h = 2016' and 5420 is '.real_rot_en_w/h =
>> 2048'.
>>
>> So my opinion they must have different compatible.
> I think there is some misunderstanding, mu suggestion was to keep the
> "samsung,exynos5-gsc" compatible entry in addition to the new introduced
> ones: "samsung,exynos5250-gsc" and "samsung,exynos5420-gsc". That's in
> order to make your changes possibly backward compatible, in theory
> the updated driver should still work without changes in dts.


Thank you again for your explanation.

Yes, I understood.
I will keep "samsung,exynos5-gsc" compatible,
and add Exynos 5250/5420/5433 compatible.

Best regards,
Hoegeun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-09-11 11:40 +0200
  Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-13 04:40 +0200
    Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-09-13 11:20 +0200
      Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-13 11:30 +0200

csiph-web