Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum
Date	2017-09-15 04:00 +0200
Message-ID	<upO5b-4xh-1@gated-at.bofh.it> (permalink)
References	<upar8-4lj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ricardo,

Thank you for the patch.

On Wednesday, 13 September 2017 10:35:52 EEST Ricardo Ribalda Delgado wrote:
> max_width and max_height are swap with step_width and step_height.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> Since that this bug has been here for ever. I do not know if we should
> notify stable or not
> 
> I have also cut the lines to respect the 80 char limit
> 
> v2: Suggested by Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> -Fix indentation
> 
>  drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
> b/drivers/media/v4l2-core/v4l2-ioctl.c index b60a6b0841d1..0292f327467d
> 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -730,9 +730,9 @@ static void v4l_print_frmsizeenum(const void *arg, bool
> write_only) break;
>  	case V4L2_FRMSIZE_TYPE_STEPWISE:
>  		pr_cont(", min=%ux%u, max=%ux%u, step=%ux%u\n",
> -				p->stepwise.min_width,  p->stepwise.min_height,
> -				p->stepwise.step_width, p->stepwise.step_height,
> -				p->stepwise.max_width,  p->stepwise.max_height);
> +			  p->stepwise.min_width, p->stepwise.min_height,
> +			  p->stepwise.max_width, p->stepwise.max_height,
> +			  p->stepwise.step_width, p->stepwise.step_height);
>  		break;
>  	case V4L2_FRMSIZE_TYPE_CONTINUOUS:
>  		/* fall through */


-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2017-09-13 09:40 +0200
  Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum Sakari Ailus <sakari.ailus@iki.fi> - 2017-09-13 10:40 +0200
  Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-09-15 04:00 +0200

csiph-web