Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732459

Re: [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils

Show all headers | View raw

On Wed 13 Sep 09:04 PDT 2017, srinivas.kandagatla@linaro.org wrote:

> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> All Qualcomm PIL drivers require SMP2P module to get a functional PIL,
> Currently user has to explicitly select SMP2P module, after looking
> at failure logs.
> 
> Fix this by selecting SMP2P as part of dependency of pil kconfig itself.
> 

The Kconfig should describe dependencies needed by the code, not by the
system.

I agree with you that this leads to wasted time trying figure out if
we're missing drivers/modules in the kernel, but I think that needs to
be solved in a more generic way.

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/remoteproc/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 8891a8e50f12..052c9e20abb6 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -87,6 +87,7 @@ config QCOM_ADSP_PIL
>  	select QCOM_MDT_LOADER
>  	select QCOM_RPROC_COMMON
>  	select QCOM_SCM
> +	select QCOM_SMP2P

NB. QCOM_SMP2P is a user-selectable config option, so you are not
allowed to "select" it, only "depends on" it.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils srinivas.kandagatla@linaro.org - 2017-09-13 18:10 +0200
  Re: [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-09-14 19:00 +0200
    Re: [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-09-15 11:10 +0200

csiph-web