Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732339

Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping

Show all headers | View raw

On Thu, Sep 14, 2017 at 2:42 AM, John Ogness <john.ogness@linutronix.de> wrote:
> Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in
> /proc/PID/stat") stopped reporting eip/esp because it is
> racey and dangerous for executing tasks. The comment adds:
>
>     As far as I know, there are no use programs that make any
>     material use of these fields, so just get rid of them.
>
> However, existing userspace core-dump-handler applications (for
> example, minicoredumper) are using these fields since they
> provide an excellent cross-platform interface to these valuable
> pointers. So that commit introduced a user space visible
> regression.
>
> Partially revert the change and make the readout possible for
> tasks with the proper permissions and only if the target task
> has the PF_DUMPCORE flag set.

Looks okay to me.

Reviewed-by: Andy Lutomirski <luto@kernel.org>

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping John Ogness <john.ogness@linutronix.de> - 2017-09-14 11:50 +0200
  Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping Andy Lutomirski <luto@kernel.org> - 2017-09-14 17:00 +0200
  Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for  coredumping Thomas Gleixner <tglx@linutronix.de> - 2017-09-14 17:40 +0200
    Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-15 21:10 +0200
      Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping Ingo Molnar <mingo@kernel.org> - 2017-09-15 23:10 +0200
  [tip:core/urgent] fs/proc: Report eip/esp in /prod/PID/stat for  coredumping tip-bot for John Ogness <tipbot@zytor.com> - 2017-09-15 23:20 +0200
  [tip:core/urgent] fs/proc: Report eip/esp in /prod/PID/stat for  coredumping tip-bot for John Ogness <tipbot@zytor.com> - 2017-09-15 23:50 +0200

csiph-web