Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support

From	Baolin Wang <baolin.wang@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support
Date	2017-09-12 11:20 +0200
Message-ID	<uoPwl-7PF-3@gated-at.bofh.it> (permalink)
References	<uoDlv-87V-3@gated-at.bofh.it> <uoDlv-87V-5@gated-at.bofh.it> <uoIEy-31E-5@gated-at.bofh.it> <uoP3k-7qx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 12 September 2017 at 16:48, Sekhar Nori <nsekhar@ti.com> wrote:
> On Tuesday 12 September 2017 07:28 AM, Baolin Wang wrote:
>>> @@ -802,13 +821,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)
>>>         dev->clk = devm_clk_get(&pdev->dev, NULL);
>>>         if (IS_ERR(dev->clk))
>>>                 return PTR_ERR(dev->clk);
>>> -       clk_prepare_enable(dev->clk);
>
>> You removed clk enable here, I think it can not work if we did not
>> open CONFIG_PM macro. I think you should keep clk enable here, and set
>
> What do you mean by "open CONFIG_PM macro" ?

If you did not open CONFIG_PM macro, then the pm_runtime_xxx() will be
dummy functions, but now the i2c driver can not work since you did not
enable clock, right?

>
>> rpm active by pm_runtime_set_active() before issuing
>> pm_runtime_enable().
>
> Can you explain why you want to do this instead of relying on
> pm_runtime_get_sync() to enable clock?

What I mean is you should compatible whether CONFIG_PM is enabled or not.

-- 
Baolin.wang
Best Regards

Thread

[PATCH v4 0/2] i2c: davinci: Add PM Runtime Support needed by 66AK2G Franklin S Cooper Jr <fcooper@ti.com> - 2017-09-11 22:20 +0200
  [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support Franklin S Cooper Jr <fcooper@ti.com> - 2017-09-11 22:20 +0200
    Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support Baolin Wang <baolin.wang@linaro.org> - 2017-09-12 04:00 +0200
      Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support Sekhar Nori <nsekhar@ti.com> - 2017-09-12 10:50 +0200
        Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support Baolin Wang <baolin.wang@linaro.org> - 2017-09-12 11:20 +0200
          Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support Sekhar Nori <nsekhar@ti.com> - 2017-09-12 11:30 +0200
  [PATCH v4 2/2] dt-bindings: i2c: i2c-davinci: Update binding for 66AK2Gx pwr dm property Franklin S Cooper Jr <fcooper@ti.com> - 2017-09-11 22:20 +0200
  Re: [PATCH v4 0/2] i2c: davinci: Add PM Runtime Support needed by  66AK2G Sekhar Nori <nsekhar@ti.com> - 2017-09-18 18:10 +0200

csiph-web