Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730668

Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead

Show all headers | View raw

Minchan Kim <minchan@kernel.org> writes:

> page_cluster 0 means "we don't want readahead" so in the case,
> let's skip the readahead detection logic.
>
> Cc: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
>  include/linux/swap.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index 0f54b491e118..739d94397c47 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -427,7 +427,8 @@ extern bool has_usable_swap(void);
>  
>  static inline bool swap_use_vma_readahead(void)
>  {
> -	return READ_ONCE(swap_vma_readahead) && !atomic_read(&nr_rotate_swap);
> +	return page_cluster > 0 && READ_ONCE(swap_vma_readahead)
> +				&& !atomic_read(&nr_rotate_swap);
>  }
>  
>  /* Swap 50% full? Release swapcache more aggressively.. */

Now the readahead window size of the VMA based swap readahead is
controlled by /sys/kernel/mm/swap/vma_ra_max_order, while that of the
original swap readahead is controlled by sysctl page_cluster.  It is
possible for anonymous memory to use VMA based swap readahead and tmpfs
to use original swap readahead algorithm at the same time.  So that, I
think it is necessary to use different control knob to control these two
algorithm.  So if we want to disable readahead for tmpfs, but keep it
for VMA based readahead, we can set 0 to page_cluster but non-zero to
/sys/kernel/mm/swap/vma_ra_max_order.  With your change, this will be
impossible.

Best Regards,
Huang, Ying

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim <minchan@kernel.org> - 2017-09-12 04:40 +0200
  Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead "Huang\, Ying" <ying.huang@intel.com> - 2017-09-12 07:30 +0200
    Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim <minchan@kernel.org> - 2017-09-12 08:30 +0200
      Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead "Huang\, Ying" <ying.huang@intel.com> - 2017-09-12 08:50 +0200
        Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim <minchan@kernel.org> - 2017-09-12 09:00 +0200
          Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead "Huang\, Ying" <ying.huang@intel.com> - 2017-09-12 09:30 +0200
            Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim <minchan@kernel.org> - 2017-09-12 10:00 +0200
              Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead "Huang\, Ying" <ying.huang@intel.com> - 2017-09-12 10:10 +0200
                Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim <minchan@kernel.org> - 2017-09-12 10:30 +0200
                Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead "Huang\, Ying" <ying.huang@intel.com> - 2017-09-12 10:40 +0200
                Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim <minchan@kernel.org> - 2017-09-13 01:40 +0200
                Re: [PATCH 4/5] mm:swap: respect page_cluster for readahead "Huang\, Ying" <ying.huang@intel.com> - 2017-09-13 03:00 +0200

csiph-web