[PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of depends on

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	[PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of depends on
Date	2017-09-06 03:50 +0200
Message-ID	<umxDz-2AZ-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

IRQ_DOMAIN_HIERARCHY is not user-configurable, but supposed to be
selected by drivers that need IRQ domain hierarchy support.

GPIO_THUNDERX is the only user of "depends on IRQ_DOMAIN_HIERARCHY".
This means, we can not enable GPIO_THUNDERX unless other drivers
select IRQ_DOMAIN_HIERARCHY elsewhere.  This is odd.  Flip the logic.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 3388d54..3f80f16 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -453,7 +453,8 @@ config GPIO_TS4800
 config GPIO_THUNDERX
 	tristate "Cavium ThunderX/OCTEON-TX GPIO"
 	depends on ARCH_THUNDER || (64BIT && COMPILE_TEST)
-	depends on PCI_MSI && IRQ_DOMAIN_HIERARCHY
+	depends on PCI_MSI
+	select IRQ_DOMAIN_HIERARCHY
 	select IRQ_FASTEOI_HIERARCHY_HANDLERS
 	help
 	  Say yes here to support the on-chip GPIO lines on the ThunderX
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of depends on Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-06 03:50 +0200
  Re: [PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of  depends on Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-06 06:30 +0200
    Re: [PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of  depends on Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-07 03:10 +0200

csiph-web