Re: Applied "regulator: pbias: Select voltage table based on max-voltage" to the regulator tree

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Applied "regulator: pbias: Select voltage table based on max-voltage" to the regulator tree
Date	2017-09-04 18:50 +0200
Message-ID	<um2Jr-7RC-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <ukwsi-5u5-21@gated-at.bofh.it> <ukyaK-6kL-23@gated-at.bofh.it> <ukU1A-5iT-15@gated-at.bofh.it> <ukWZs-7vc-23@gated-at.bofh.it> <ulSqK-1uv-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Sep 04, 2017 at 11:16:54AM +0530, Kishon Vijay Abraham I wrote:
> On Friday 01 September 2017 09:53 PM, Mark Brown wrote:

> > Hang on, how can this break anything?  If it breaks things shouldn't
> > there be bugfixes for incorrect constraints somewhere?

> omap_hsmmc sets the pbias voltage to 3V. But here we program the volt table to
> support either 1.8V or 3.3V (Initially the volt table was programmed to support
> 3V because of a bug in TRM). So set_voltage of pbias voltage in omap_hsmmc will
> fail.

Oh, that's appauling.  I guess this is some voltage that doesn't get
presented to cards because otherwise I'm surprised nobody noticed.
Anyway I've dropped the commit from my pull request for now, it'll not
go for v4.14, but the pull request is still there.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] mmc: Add OMAP SDHCI driver Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-31 12:30 +0200
  [PATCH v2 6/6] MAINTAINERS: Add TI OMAP SDHCI Maintainer Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-31 12:30 +0200
  [PATCH v2 1/6] mmc: host: omap_hsmmc: Remove setting PBIAS voltage Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-31 12:30 +0200
  [PATCH v2 3/6] ARM: dts: dra7: Increase max-voltage of pbias regulator Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-31 12:30 +0200
  [PATCH v2 4/6] dt-bindings: sdhci-omap: Add bindings for the sdhci-omap controller Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-31 12:30 +0200
  [PATCH v2 2/6] regulator: pbias: Select voltage table based on max-voltage Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-31 12:30 +0200
    Applied "regulator: pbias: Select voltage table based on max-voltage" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-08-31 14:00 +0200
      Re: Applied "regulator: pbias: Select voltage table based on  max-voltage" to the regulator tree Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-31 14:10 +0200
        Re: Applied "regulator: pbias: Select voltage table based on  max-voltage" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-08-31 16:00 +0200
          Re: Applied "regulator: pbias: Select voltage table based on  max-voltage" to the regulator tree Ulf Hansson <ulf.hansson@linaro.org> - 2017-09-01 15:20 +0200
            Re: Applied "regulator: pbias: Select voltage table based on  max-voltage" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-09-01 18:30 +0200
              Re: Applied "regulator: pbias: Select voltage table based on  max-voltage" to the regulator tree Kishon Vijay Abraham I <kishon@ti.com> - 2017-09-04 07:50 +0200
                Re: Applied "regulator: pbias: Select voltage table based on  max-voltage" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-09-04 18:50 +0200

csiph-web