Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723445

Re: [PATCH V1] regulator: pv88090: Exception handling for out of bounds

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 30, 2017 at 05:54:27PM +0900, Eric Jeong wrote:

I've applied this but a few things to bear in mind for future
submissions:

> From: Eric Jeong <eric.jeong.opensource@diasemi.com>

Please try to ensure that your e-mail address matches the one you use
for signoff, this avoids your mail looking like a non-author send that's
missing a signoff.

> This is a patch for exception handlding that the index of array is
> out of bounds. And the definitions have been updated to use
> proper device name.

This'd be easier to review with the rename separated out from the
functional change.

> @@ -43,7 +43,7 @@ enum {
>  struct pv88090_regulator {
>  	struct regulator_desc desc;
>  	/* Current limiting */
> -	unsigned	n_current_limits;
> +	unsigned int n_current_limits;

This is fine but it's an unrelated stylistic change.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V1] regulator: pv88090: Exception handling for out of bounds Eric Jeong <eric.jeong.opensource@diasemi.com> - 2017-08-30 11:10 +0200
  Re: [PATCH V1] regulator: pv88090: Exception handling for out of  bounds Mark Brown <broonie@kernel.org> - 2017-08-30 17:20 +0200
  Applied "regulator: pv88090: Exception handling for out of bounds" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-08-30 17:30 +0200

csiph-web