Re: [PATCH] staging: rtl8723bs: remove memset before memcpy

From	Himanshu Jha <himanshujha199640@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8723bs: remove memset before memcpy
Date	2017-08-28 09:20 +0200
Message-ID	<ujmv0-2AD-9@gated-at.bofh.it> (permalink)
References	<ujcci-47d-1@gated-at.bofh.it> <ujlyW-1YD-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 28, 2017 at 09:19:06AM +0300, Dan Carpenter wrote:
> On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote:
> > calling memcpy immediately after memset with the same region of memory
> > makes memset redundant.
> > 
> > Build successfully.
> > 
> 
> Thanks for the patch, it looks good.  You don't need to say that it
> builds successfully, because we already assume that's true.
> 
> > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> > ---
> 
> Sometimes I put a comment here under the cut off line if I want people
> to know that I haven't tested a patch.
> 
> Anyway, don't resend the patch.  It's fine as-is (unless Greg
> complains) but it's just for future reference.

Thanks for the feedback and i will keep that in mind for future patches.
Himanshu Jha
> 
> regards,
> dan carpenter
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8723bs: remove memset before memcpy Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-27 22:20 +0200
  Re: [PATCH] staging: rtl8723bs: remove memset before memcpy Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-28 08:20 +0200
    Re: [PATCH] staging: rtl8723bs: remove memset before memcpy Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-28 09:20 +0200

csiph-web