Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720932

Re: [PATCH] staging: atomisp: constify v4l2_subdev_sensor_ops

Show all headers | View raw

Hi Arvind,

On Sun, Aug 27, 2017 at 11:26:39AM +0530, Arvind Yadav wrote:
> v4l2_subdev_sensor_ops are not supposed to change at runtime.
> v4l2_subdev_sensor_ops are working with const 'sensor' field of
> sturct v4l2_subdev_ops. So mark the non-const v4l2_subdev_sensor_ops
> structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks for the patch. The change has already been made by this patch:

commit 65058214f5c2ebe844916b92d1bece64fd00206e
Author: Julia Lawall <Julia.Lawall@lip6.fr>
Date:   Tue Aug 8 06:58:29 2017 -0400

    media: staging: media: atomisp: constify video_subdev structures
    
    These structures are both stored in fields of v4l2_subdev_ops
    structures, all of which are const, so these structures can be
    const as well.
    
    Done with the help of Coccinelle.
    
    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: atomisp: constify v4l2_subdev_sensor_ops Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-27 08:00 +0200
  Re: [PATCH] staging: atomisp: constify v4l2_subdev_sensor_ops Sakari Ailus <sakari.ailus@iki.fi> - 2017-08-27 23:50 +0200

csiph-web