Groups > linux.kernel > #1720906

Re: [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO

From	Matthias Brugger <matthias.bgg@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO
Date	2017-08-27 20:50 +0200
Message-ID	<ujaNb-32e-9@gated-at.bofh.it> (permalink)
References	<uiZoJ-3VU-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 08/27/2017 09:31 AM, Himanshu Jha wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
>   drivers/tty/serial/8250/8250_mtk.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index ce0cc47..fb45770 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -171,10 +171,7 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,
>   	}
>   
>   	data->bus_clk = devm_clk_get(&pdev->dev, "bus");
> -	if (IS_ERR(data->bus_clk))
> -		return PTR_ERR(data->bus_clk);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(data->bus_clk);
>   }
>   

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-27 08:40 +0200
  Re: [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO Matthias Brugger <matthias.bgg@gmail.com> - 2017-08-27 20:50 +0200

csiph-web