Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1722457

[PATCH] perf probe: Fix kprobe blacklist checking condition

Show all headers | View raw

The commit 9aaf5a5("perf probe: Check kprobes blacklist
when adding new events"), perf probe supports checking
the blacklist of the fuctions which can not be probed.
But the checking condition is wrong, that the end_addr
of the symbol which is the start_addr of the next symbol
can't be included.

Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
 tools/perf/util/probe-event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index a2670e9..bf7c928 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2373,7 +2373,7 @@ static int kprobe_blacklist__load(struct list_head *blacklist)
 	struct kprobe_blacklist_node *node;
 
 	list_for_each_entry(node, blacklist, list) {
-		if (node->start <= address && address <= node->end)
+		if (node->start <= address && address < node->end)
 			return node;
 	}
 
-- 
1.7.12.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf probe: Fix kprobe blacklist checking condition Li Bin <huawei.libin@huawei.com> - 2017-08-29 15:10 +0200
  Re: [PATCH] perf probe: Fix kprobe blacklist checking condition Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-29 17:00 +0200
  [tip:perf/core] perf probe: Fix kprobe blacklist checking condition tip-bot for Li Bin <tipbot@zytor.com> - 2017-08-29 23:30 +0200
  Re: [PATCH] perf probe: Fix kprobe blacklist checking condition Masami Hiramatsu <mhiramat@kernel.org> - 2017-08-30 14:30 +0200

csiph-web