Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720820

Re: Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session]

From Greg KH <greg@kroah.com>
Newsgroups linux.kernel
Subject Re: Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session]
Date 2017-08-27 15:20 +0200
Message-ID <uj5DP-8ab-7@gated-at.bofh.it> (permalink)
References <tWV8t-6Z7-15@gated-at.bofh.it> <tX2CZ-3Ko-7@gated-at.bofh.it> <uhygW-5YE-15@gated-at.bofh.it> <uhIpX-3XR-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Aug 23, 2017 at 08:14:15PM +0200, Marcel Holtmann wrote:
> Hi Jiri,
> 
> >>> It looks like bnep_session has same pattern as the issue reported in
> >>> old rfcomm:
> >>> 
> >>> 	while (1) {
> >>> 		set_current_state(TASK_INTERRUPTIBLE);
> >>> 		if (condition)
> >>> 			break;
> >>> 		// may call might_sleep here
> >>> 		schedule();
> >>> 	}
> >>> 	__set_current_state(TASK_RUNNING);
> >>> 
> >>> Which fixed at:
> >>> 	dfb2fae Bluetooth: Fix nested sleeps
> >>> 
> >>> So let's fix it at the same way, also follow the suggestion of:
> >>> https://lwn.net/Articles/628628/
> > 
> > ...
> > 
> >> all 3 patches have been applied to bluetooth-next tree.
> > 
> > Hi,
> > 
> > given users are hitting it in at least 4.4 and 4.12, can we have all
> > three in all stables where this applies?
> > 
> > 5da8e47d849d Bluetooth: hidp: fix possible might sleep error in
> > hidp_session_thread
> > f06d977309d0 Bluetooth: cmtp: fix possible might sleep error in cmtp_session
> > 25717382c1dd Bluetooth: bnep: fix possible might sleep error in bnep_session
> > 
> > I am not sure: to stable directly or via net stable?
> 
> as Dave said, just email -stable directly and have Greg pick them up.

All now picked up :)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: Stable apply request [was: Bluetooth: bnep: fix possible might  sleep error in bnep_session] Greg KH <greg@kroah.com> - 2017-08-27 15:20 +0200

csiph-web