Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720690

Re: [PATCH] iommu/mediatek: Fix a build fail of m4u_type

From Matthias Brugger <matthias.bgg@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] iommu/mediatek: Fix a build fail of m4u_type
Date 2017-08-26 20:50 +0200
Message-ID <uiOjD-4Oa-1@gated-at.bofh.it> (permalink)
References <uhSSl-2bC-5@gated-at.bofh.it> <uiO9Y-4IU-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 08/26/2017 09:33 PM, Matthias Brugger wrote:
> 
> 
> On 08/24/2017 08:24 AM, Yong Wu wrote:
>> The commit ("iommu/mediatek: Enlarge the validate PA range
>> for 4GB mode") introduce the following build error:
>>
>>     drivers/iommu/mtk_iommu.c: In function 'mtk_iommu_hw_init':
>>>> drivers/iommu/mtk_iommu.c:536:30: error: 'const struct mtk_iommu_data'
>>   has no member named 'm4u_type'; did you mean 'm4u_dom'?
>>       if (data->enable_4GB && data->m4u_type != M4U_MT8173) {
>>
>> This patch fix it, use "m4u_plat" instead of "m4u_type".
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
>> ---
>> 1) In the v2 of mt2712 iommu support patch-set, We changed a variant
>> name from "m4u_type" to "m4u_plat", But I'm sorry that I forgot to
>> change it in the later patch.
>> 2) This patch is based on [1].
>> [1]:https://lists.linuxfoundation.org/pipermail/iommu/2017-August/023847.html
>> 3) I cann't find the commit id of the patch ("iommu/mediatek: Enlarge
>> the validate PA range for 4GB mode") in the [2].
>> So I don't write the commit id for that patch in the commit message.
>> [2]https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
> 
> Because the kernel test robot took the patch from the mailinglist. Please fold 
> this fix into v3 of the series.
> 

Please ignore this message, I didn't realize that the driver was already queued 
by Joerg.

Regards,
Matthias

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] iommu/mediatek: Fix a build fail of m4u_type Matthias Brugger <matthias.bgg@gmail.com> - 2017-08-26 20:40 +0200
  Re: [PATCH] iommu/mediatek: Fix a build fail of m4u_type Matthias Brugger <matthias.bgg@gmail.com> - 2017-08-26 20:50 +0200

csiph-web