Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717896

Re: [PATCH net] fsl/man: Inherit parent device and of_node

Show all headers | View raw

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 22 Aug 2017 15:24:47 -0700

> Junote Cai reported that he was not able to get a DSA setup involving the
> Freescale DPAA/FMAN driver to work and narrowed it down to
> of_find_net_device_by_node(). This function requires the network device's
> device reference to be correctly set which is the case here, though we have
> lost any device_node association there.
> 
> The problem is that dpaa_eth_add_device() allocates a "dpaa-ethernet" platform
> device, and later on dpaa_eth_probe() is called but SET_NETDEV_DEV() won't be
> propagating &pdev->dev.of_node properly. Fix this by inherenting both the parent
> device and the of_node when dpaa_eth_add_device() creates the platform device.
> 
> Fixes: 3933961682a3 ("fsl/fman: Add FMan MAC driver")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied and queued up for -stable, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] fsl/man: Inherit parent device and of_node Florian Fainelli <f.fainelli@gmail.com> - 2017-08-23 00:30 +0200
  Re: [PATCH net] fsl/man: Inherit parent device and of_node David Miller <davem@davemloft.net> - 2017-08-23 01:40 +0200

csiph-web