Re: [PATCH v2] Do not disable driver and bus shutdown hook when class shutdown hook is set.

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] Do not disable driver and bus shutdown hook when class shutdown hook is set.
Date	2017-08-19 19:40 +0200
Message-ID	<ugfT3-4bZ-1@gated-at.bofh.it> (permalink)
References	<udiu6-4b4-23@gated-at.bofh.it> <ugaJI-19w-13@gated-at.bofh.it> <ugfq2-42G-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sat, Aug 19, 2017 at 10:03:40AM -0700, Greg Kroah-Hartman wrote:
> On Sat, Aug 19, 2017 at 03:03:53PM +0300, Jarkko Sakkinen wrote:
> > On Fri, Aug 11, 2017 at 03:44:43PM +0200, Michal Suchanek wrote:
> > > As seen from the implementation of the single class shutdown hook this
> > > is not very sound design.
> > > 
> > > Rename the class shutdown hook to shutdown_pre to make it clear it runs
> > > before the driver shutdown hook.
> > > 
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > 
> > I already gave this reviewed-by but cannot apply it because there's no
> > ack from device maintainers yet.
> 
> I'm on vacation at the moment and will look at this when I get back in a
> week, please give me a chance.
> 
> thanks,
> 
> greg k-h

Take your time! I don't think this patch is critical. Thanks.

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] Do not disable driver and bus shutdown hook when  class shutdown hook is set. Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-08-19 14:10 +0200
  Re: [PATCH v2] Do not disable driver and bus shutdown hook when  class shutdown hook is set. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-19 19:10 +0200
    Re: [PATCH v2] Do not disable driver and bus shutdown hook when  class shutdown hook is set. Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-08-19 19:40 +0200

csiph-web