Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1715984

[PATCH 2/3] ceph: Delete an unnecessary return statement in update_dentry_lease()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 20 Aug 2017 20:08:25 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 fs/ceph/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index 010e7be768e6..8eae56b2d1d6 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -1067,7 +1067,6 @@ static void update_dentry_lease(struct dentry *dentry,
 	spin_unlock(&dentry->d_lock);
 	if (old_lease_session)
 		ceph_put_mds_session(old_lease_session);
-	return;
 }
 
 /*
-- 
2.14.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Ceph: Adjustments for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-20 20:40 +0200
  [PATCH 1/3] ceph: Delete an error message for a failed memory  allocation in __get_or_create_frag() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-20 20:40 +0200
  [PATCH 2/3] ceph: Delete an unnecessary return statement in  update_dentry_lease() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-20 20:50 +0200
  [PATCH 3/3] ceph: Adjust 36 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-20 20:50 +0200
  Re: [PATCH 0/3] Ceph: Adjustments for some function implementations "Yan, Zheng" <zyan@redhat.com> - 2017-08-21 03:50 +0200

csiph-web