Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713244

Re: [PATCH v2 1/2] paravirt,xen: remove xen_patch()

From Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/2] paravirt,xen: remove xen_patch()
Date 2017-08-16 21:20 +0200
Message-ID <ufc1c-2Al-9@gated-at.bofh.it> (permalink)
References <ufasq-1zg-7@gated-at.bofh.it> <ufasq-1zg-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 16, 2017 at 07:31:56PM +0200, Juergen Gross wrote:
>  ENTRY(xen_irq_disable_direct)
>  	movb $1, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask
> -ENDPATCH(xen_irq_disable_direct)
>  	ret
>  	ENDPROC(xen_irq_disable_direct)
> -	RELOC(xen_irq_disable_direct, 0)

Might as well remove the ENDPROC indentations while you're at it, for
readability and consistency with other asm code.

Otherwise,

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] paravirt,xen: remove xen_patch() Juergen Gross <jgross@suse.com> - 2017-08-16 19:40 +0200
  Re: [PATCH v2 1/2] paravirt,xen: remove xen_patch() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-08-16 21:20 +0200
  Re: [PATCH v2 1/2] paravirt,xen: remove xen_patch() Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-18 15:30 +0200
  [tip:x86/asm] x86/paravirt/xen: Remove xen_patch() tip-bot for Juergen Gross <tipbot@zytor.com> - 2017-08-24 10:40 +0200

csiph-web