Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713052

Re: [PATCH] udc: Memory leak on error path and use after free

Show all headers | View raw

On Wed, 16 Aug 2017, Anton Vasilyev wrote:

> gadget_release() is responsible for cleanup dev memory.
> But if net2280_probe() fails after dev allocation, then
> gadget_release() become unregistered and dev memory leaks.

This isn't needed if usb_add_gadget_udc_release() is fixed, right?

> Also net2280_remove() calls usb_del_gadget_udc() which
> perform schedule_delayed_work() with gadget_release(), so
> it is possible that dev will be deallocated exactly after
> this call and leads to use after free.

Where is there a possible use after free?

> The patch moves deallocation from gadget_release() to
> net2280_remove().

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] udc: Memory leak on error path and use after free Anton Vasilyev <vasilyev@ispras.ru> - 2017-08-16 15:50 +0200
  Re: [PATCH] udc: Memory leak on error path and use after free Alan Stern <stern@rowland.harvard.edu> - 2017-08-16 17:30 +0200
    Re: [PATCH] udc: Memory leak on error path and use after free Anton Vasilyev <vasilyev@ispras.ru> - 2017-08-16 18:10 +0200
      Re: [PATCH] udc: Memory leak on error path and use after free Alan Stern <stern@rowland.harvard.edu> - 2017-08-16 18:40 +0200
        Re: [PATCH] udc: Memory leak on error path and use after free Anton Vasilyev <vasilyev@ispras.ru> - 2017-08-22 17:50 +0200
          Re: [PATCH] udc: Memory leak on error path and use after free Alan Stern <stern@rowland.harvard.edu> - 2017-08-22 20:40 +0200

csiph-web