Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

From	David Ahern <dsahern@gmail.com>
Newsgroups	linux.kernel
Subject	Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1
Date	2017-08-14 01:10 +0200
Message-ID	<ueab7-4ST-7@gated-at.bofh.it> (permalink)
References	(9 earlier) <udsjM-1Rd-9@gated-at.bofh.it> <udJaV-4mD-1@gated-at.bofh.it> <udKA2-5bj-19@gated-at.bofh.it> <ue3W1-YX-1@gated-at.bofh.it> <ue89k-3tL-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 8/13/17 2:56 PM, Wei Wang wrote:
>> Looking at my patch to move host routes from loopback to device with the
>> address, I have this:
>>
>> @@ -2789,7 +2808,8 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg)
>>         const struct arg_dev_net *adn = arg;
>>         const struct net_device *dev = adn->dev;
>>
>> -       if ((rt->dst.dev == dev || !dev) &&
>> +       if ((rt->dst.dev == dev || !dev ||
>> +            (netdev_unregistering(dev) && rt->rt6i_idev->dev == dev)) &&
>>             rt != adn->net->ipv6.ip6_null_entry &&
>>             (rt->rt6i_nsiblings == 0 ||
>>              (dev && netdev_unregistering(dev)) ||
> 
> As you explained earlier, after your patch, all entries in the fib6
> tree will have rt->dst.dev be the same as rt->rt6i_idev->dev except
> those ones created by p6_rt_cache_alloc() and ip6_rt_pcpu_alloc().
> Then the above newly added check is mainly to catch those cached dst
> entries (created by ip6_rt_cached_alloc()). right?
> And it is required because __ipv6_ifa_notify() -> ip6_del_rt() won't
> take care of those cached dst entries.
> 
> Then I think I should wait for your patches to get merged before
> submitting my patch?

no. your patch will need to go back to 4.12; my changes will not be
appropriate for that.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 Wei Wang <weiwan@google.com> - 2017-08-12 02:20 +0200
  Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 John Stultz <john.stultz@linaro.org> - 2017-08-12 02:40 +0200
    Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 Wei Wang <weiwan@google.com> - 2017-08-12 02:50 +0200
    Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 John Stultz <john.stultz@linaro.org> - 2017-08-12 05:10 +0200
      Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 Wei Wang <weiwan@google.com> - 2017-08-12 21:30 +0200
      Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 Wei Wang <weiwan@google.com> - 2017-08-12 21:30 +0200
  Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 Ido Schimmel <idosch@idosch.org> - 2017-08-12 20:20 +0200
    Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 Wei Wang <weiwan@google.com> - 2017-08-12 21:50 +0200
      Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 David Ahern <dsahern@gmail.com> - 2017-08-13 18:30 +0200
        Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 Wei Wang <weiwan@google.com> - 2017-08-13 23:00 +0200
          Re: unregister_netdevice: waiting for eth0 to become free. Usage  count = 1 David Ahern <dsahern@gmail.com> - 2017-08-14 01:10 +0200

csiph-web