Re: [PATCH] ARM: bcm2836: Send event when onlining other cores

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: bcm2836: Send event when onlining other cores
Date	2017-08-15 20:10 +0200
Message-ID	<ueOrU-4Hl-11@gated-at.bofh.it> (permalink)
References	<ucayE-7uw-61@gated-at.bofh.it> <ucb1D-7Kd-19@gated-at.bofh.it> <ueqpA-6qC-17@gated-at.bofh.it> <uerbZ-6WD-25@gated-at.bofh.it> <uesB4-7Hs-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi Eric,
>
>> Stefan Wahren <stefan.wahren@i2se.com> hat am 14. August 2017 um 19:11 geschrieben:
>> 
>> 
>> Hi Florian,
>> 
>> > Florian Fainelli <f.fainelli@gmail.com> hat am 14. August 2017 um 18:25 geschrieben:
>> > 
>> > 
>> > 
>> > 
>> > On 08/08/2017 04:04 AM, Phil Elwell wrote:
>> > > Secondary cores should enter a low-power idle state when waiting to
>> > > be started. The "wfe" instruction causes a core to wait until an event
>> > > or interrupt arrives before continuing to the next instruction, and
>> > > the "sev" instruction sends a wakeup event to the other cores.
>> > > 
>> > > Add an "sev" (and a memory barrier) to bcm2836_boot_secondary, the
>> > > function that wakes the waiting cores during booting. This is required
>> > > if the secondary cores are sitting in "wfe", and harmless if not.
>> > 
>> > Eric, should I just pick this up for the upcoming ARM SoC pull requests
>> > that I am preparing, or do you have more changes aside from the two tags
>> > I already merged?
>> 
>> this patch depends on series "ARM: bcm2836: Move SMP startup code to arch/arm".
>> 
>> I didn't had the time to test Phil's patch in all relevant cases. But i could at least prepare a branch with my changes with the acks.
>
> i prepared the branches bcm2835-dt-next-v2 and bcm2835-soc-next.

bcm2835-soc-next on its own breaks boot for me on the Pi2, so I had to
merge in the DT branch first.  I've rebased to do that, pulled in this
patch (and the clk one), and sent PRs for -dt and -soc.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: bcm2836: Send event when onlining other cores Florian Fainelli <f.fainelli@gmail.com> - 2017-08-14 18:30 +0200
  Re: [PATCH] ARM: bcm2836: Send event when onlining other cores Stefan Wahren <stefan.wahren@i2se.com> - 2017-08-14 19:20 +0200
    Re: [PATCH] ARM: bcm2836: Send event when onlining other cores Stefan Wahren <stefan.wahren@i2se.com> - 2017-08-14 20:50 +0200
      Re: [PATCH] ARM: bcm2836: Send event when onlining other cores Eric Anholt <eric@anholt.net> - 2017-08-15 20:10 +0200

csiph-web