Re: [PATCH v3 08/10] clk: sunxi-ng: support R40 SoC

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 08/10] clk: sunxi-ng: support R40 SoC
Date	2017-08-12 06:10 +0200
Message-ID	<udvUm-4bG-9@gated-at.bofh.it> (permalink)
References	<tLH8R-1Wq-5@gated-at.bofh.it> <tLH8R-1Wq-13@gated-at.bofh.it> <tMnrr-52Q-3@gated-at.bofh.it> <u5SXL-4XE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 22, 2017 at 11:00 AM,  <icenowy@aosc.io> wrote:
> 在 2017-05-29 15:34，Chen-Yu Tsai 写道：
>>
>> Hi,
>>
>> On Sat, May 27, 2017 at 06:23:06PM +0800, Icenowy Zheng wrote:

[...]

>>> +
>>> +/*
>>> + * For the special bit in gate part, please see the BSP source code at
>>> + *
>>> https://github.com/BPI-SINOVOIP/BPI-M2U-bsp/blob/master/linux-sunxi/drivers/clk/sunxi/clk-sun8iw11.c#L665
>>> + */
>>> +static SUNXI_CCU_NKM_WITH_GATE_LOCK(pll_sata_clk, "pll-sata",
>>> +                                   "osc24M", 0x034,
>>> +                                   8, 5,       /* N */
>>> +                                   4, 2,       /* K */
>>> +                                   0, 2,       /* M */
>>> +                                   BIT(31) | BIT(14),  /* gate */
>>> +                                   BIT(28),    /* lock */
>>> +                                   0);
>>
>>
>> I think this is a somewhat simplified approach. From what I understand
>> of the user manual, the SATA clock path look like:
>>
>>
>> [ PLL-PERIPH0-SATA ] -\
>>                       mux @ 0x34 bit 30 --- gate @ 0x34 bit 14 --- ...
>> [ PLL-SATA ] ---------/
>>
>> ... from above ... ------\
>>                          mux @ 0xc8 bit 24 --- gate @ 0xc8 bit 31
>> [ external oscillator ] -/
>>
>> If you choose to simplify the implementation, please include a detailed
>> note as to why you chose to do so, and the validity of the simplification.
>
>
> I think it can be fully implemented...
>
> But how should I call the internal clock controlled by the mux @ 0x34 bit
> 30?

sata-pll-mux?

ChenYu

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 08/10] clk: sunxi-ng: support R40 SoC Chen-Yu Tsai <wens@csie.org> - 2017-08-12 06:10 +0200
  Re: [PATCH v3 08/10] clk: sunxi-ng: support R40 SoC icenowy@aosc.io - 2017-08-12 07:00 +0200
    Re: [PATCH v3 08/10] clk: sunxi-ng: support R40 SoC Chen-Yu Tsai <wens@csie.org> - 2017-08-12 07:20 +0200

csiph-web