Re: [PATCH v4 4/5] squashfs: Add zstd support

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/5] squashfs: Add zstd support
Date	2017-08-13 10:40 +0200
Message-ID	<udWBb-4Qg-3@gated-at.bofh.it> (permalink)
References	<uaRol-3le-5@gated-at.bofh.it> <uaRol-3le-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 4, 2017 at 10:19 PM, Nick Terrell <terrelln@fb.com> wrote:
> --- a/fs/squashfs/decompressor.c
> +++ b/fs/squashfs/decompressor.c
> @@ -65,6 +65,12 @@ static const struct squashfs_decompressor squashfs_zlib_comp_ops = {
>  };
>  #endif
>
> +#ifndef CONFIG_SQUASHFS_ZSTD
> +static const struct squashfs_decompressor squashfs_zstd_comp_ops = {
> +       NULL, NULL, NULL, NULL, ZSTD_COMPRESSION, "zstd", 0

Can you please use designated initializers?

> +};
> +#endif
> +
>  static const struct squashfs_decompressor squashfs_unknown_comp_ops = {
>         NULL, NULL, NULL, NULL, 0, "unknown", 0
> ;

> +const struct squashfs_decompressor squashfs_zstd_comp_ops = {
> +       .init = zstd_init,
> +       .free = zstd_free,
> +       .decompress = zstd_uncompress,
> +       .id = ZSTD_COMPRESSION,
> +       .name = "zstd",
> +       .supported = 1
> +};

... like you did here.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[PATCH v4 4/5] squashfs: Add zstd support Nick Terrell <terrelln@fb.com> - 2017-08-04 22:30 +0200
  Re: [PATCH v4 4/5] squashfs: Add zstd support Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-05 00:20 +0200
    Re: [PATCH v4 4/5] squashfs: Add zstd support Nick Terrell <terrelln@fb.com> - 2017-08-05 00:40 +0200
  Re: [PATCH v4 4/5] squashfs: Add zstd support Sean Purcell <me@seanp.xyz> - 2017-08-05 01:50 +0200
  Re: [PATCH v4 4/5] squashfs: Add zstd support Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-13 10:40 +0200
    Re: [PATCH v4 4/5] squashfs: Add zstd support Phillip Lougher <phillip.lougher@gmail.com> - 2017-08-14 04:30 +0200

csiph-web