Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

From	"Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only
Date	2017-08-13 03:00 +0200
Message-ID	<udPq2-8h4-3@gated-at.bofh.it> (permalink)
References	<udmR4-6UV-13@gated-at.bofh.it> <udFK1-1Z6-9@gated-at.bofh.it> <udGZr-2Jb-1@gated-at.bofh.it> <udNey-6XD-11@gated-at.bofh.it> <udODD-7Ym-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 13, 2017 at 2:00 AM, Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
> On Sun, 2017-08-13 at 00:37 +0200, Rafael J. Wysocki wrote:
>> On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada
>> <srinivas.pandruvada@linux.intel.com> wrote:
>> >
>> > On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote:
>> > [...]
>> >
>> > >
>> > > >
>> > > > +
>> > > > +struct lpi_constraints {
>> > > > +   char *name;
>> > > > +   int min_dstate;
>> > > If you store the handle here as well, you won't need to
>> > > look it up every time _check_constraints() is called.
>> > The reason I didn't keep handle here, I thought handle can be stale
>> > or
>> > change for PnP device on plug in and out. Is this not true?
>> The handles don't go away on hot remove as a rule.  That may only
>> happen if tables get unloaded, but basically the constraints should
>> not point to anything in a table that may go away.
>
> So we don't need to worry about this case where tables gets unloaded
> and replaced?

I wouldn't. :-)

We generally don't support that case entirely, so why bother?

> This is in a debug path, so additional overhead of path
> to handle conversion may not be significant.

Well, it still is wasted cycles ...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-08-11 20:30 +0200
  Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-12 16:40 +0200
    Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for  debug only Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-08-12 18:00 +0200
      Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for  debug only "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-13 00:40 +0200
        Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for  debug only Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-08-13 02:10 +0200
          Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for  debug only "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-13 03:00 +0200

csiph-web