Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706983

Re: [PATCH] acpi: apei: fix GHES estatus iteration

Show all headers | View raw

On Tuesday, August 8, 2017 6:32:20 PM CEST Will Deacon wrote:
> On Thu, Aug 03, 2017 at 03:32:25PM -0600, Tyler Baicar wrote:
> > Currently iterating through the GHES estatus blocks does not
> > take into account the new generic data v3 structure size. This
> > can result in garbage non-standard trace events to be triggered
> > since the loop will not properly iterate through the estatus
> > blocks and not properly terminate.
> > 
> > Update the GHES estatus iteration to properly increment through
> > the estatus blocks similar to how the CPER estatus printing
> > iterates through them.
> > 
> > Fixes: bbcc2e7b642e ("ras: acpi/apei: cper: add support for generic data v3 structure")
> > Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> > Tested-by: Austin Christ <austinwc@codeaurora.org>
> > ---
> >  drivers/acpi/apei/apei-internal.h | 5 -----
> >  drivers/acpi/apei/ghes.c          | 8 +++++++-
> >  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> Whilst much of the initial code here went through the arm64 tree in the
> previous merge window, I'm assuming that Boris will take this fix via his
> tree (likewise for "[PATCH V2] acpi: apei: clear error status before
> acknowledging the error").

Actually I will if Boris ACKs these.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi: apei: fix GHES estatus iteration Tyler Baicar <tbaicar@codeaurora.org> - 2017-08-03 23:40 +0200
  Re: [PATCH] acpi: apei: fix GHES estatus iteration Will Deacon <will.deacon@arm.com> - 2017-08-08 18:40 +0200
    Re: [PATCH] acpi: apei: fix GHES estatus iteration "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-09 03:10 +0200
      Re: [PATCH] acpi: apei: fix GHES estatus iteration Borislav Petkov <bp@suse.de> - 2017-08-09 07:00 +0200
      Re: [PATCH] acpi: apei: fix GHES estatus iteration gengdongjiu <gengdongjiu@huawei.com> - 2017-08-11 00:10 +0200
        Re: [PATCH] acpi: apei: fix GHES estatus iteration "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-11 15:20 +0200

csiph-web