Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1708501

[tip:sched/core] sched/deadline: Don't re-initialize 'struct cpudl'

From tip-bot for Viresh Kumar <tipbot@zytor.com>
Newsgroups linux.kernel
Subject [tip:sched/core] sched/deadline: Don't re-initialize 'struct cpudl'
Date 2017-08-10 14:10 +0200
Message-ID <ucUrN-5pA-33@gated-at.bofh.it> (permalink)
References <tvJ51-Rx-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Commit-ID:  42d394d41ab90f4ed9d7a7403ed22e8f7590948a
Gitweb:     http://git.kernel.org/tip/42d394d41ab90f4ed9d7a7403ed22e8f7590948a
Author:     Viresh Kumar <viresh.kumar@linaro.org>
AuthorDate: Thu, 13 Apr 2017 14:45:49 +0530
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 10 Aug 2017 12:18:13 +0200

sched/deadline: Don't re-initialize 'struct cpudl'

The 'struct cpudl' passed to cpudl_init() is already initialized to zero.
Don't do that again.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linaro-kernel@lists.linaro.org
Link: http://lkml.kernel.org/r/bd4c229806bc96694b15546207afcc221387d2f5.1492065513.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/cpudeadline.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
index fba235c..bdf448b 100644
--- a/kernel/sched/cpudeadline.c
+++ b/kernel/sched/cpudeadline.c
@@ -246,7 +246,6 @@ int cpudl_init(struct cpudl *cp)
 {
 	int i;
 
-	memset(cp, 0, sizeof(*cp));
 	raw_spin_lock_init(&cp->lock);
 	cp->size = 0;
 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[tip:sched/core] sched/deadline: Don't re-initialize 'struct cpudl' tip-bot for Viresh Kumar <tipbot@zytor.com> - 2017-08-10 14:10 +0200

csiph-web