Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1708265
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [virtio-dev] Re: [PATCH v13 4/5] mm: support reporting free page blocks |
| Date | 2017-08-10 09:10 +0200 |
| Message-ID | <ucPLs-2cT-17@gated-at.bofh.it> (permalink) |
| References | <uai7g-4AX-9@gated-at.bofh.it> <uaigV-4Gy-9@gated-at.bofh.it> <uaksr-6mu-35@gated-at.bofh.it> <uc61X-3Rd-1@gated-at.bofh.it> <uc6lj-3ZY-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue 08-08-17 14:34:25, Wei Wang wrote:
> On 08/08/2017 02:12 PM, Wei Wang wrote:
> >On 08/03/2017 05:11 PM, Michal Hocko wrote:
> >>On Thu 03-08-17 14:38:18, Wei Wang wrote:
> >>This is just too ugly and wrong actually. Never provide struct page
> >>pointers outside of the zone->lock. What I've had in mind was to simply
> >>walk free lists of the suitable order and call the callback for each
> >>one.
> >>Something as simple as
> >>
> >> for (i = 0; i < MAX_NR_ZONES; i++) {
> >> struct zone *zone = &pgdat->node_zones[i];
> >>
> >> if (!populated_zone(zone))
> >> continue;
> >
> >Can we directly use for_each_populated_zone(zone) here?
yes, my example couldn't because I was still assuming per-node API
> >>spin_lock_irqsave(&zone->lock, flags);
> >> for (order = min_order; order < MAX_ORDER; ++order) {
> >
> >
> >This appears to be covered by for_each_migratetype_order(order, mt) below.
yes but
#define for_each_migratetype_order(order, type) \
for (order = 0; order < MAX_ORDER; order++) \
for (type = 0; type < MIGRATE_TYPES; type++)
so you would have to skip orders < min_order
--
Michal Hocko
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v13 0/5] Virtio-balloon Enhancement Wei Wang <wei.w.wang@intel.com> - 2017-08-03 08:50 +0200
[PATCH v13 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG Wei Wang <wei.w.wang@intel.com> - 2017-08-03 09:00 +0200
Re: [PATCH v13 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG "Michael S. Tsirkin" <mst@redhat.com> - 2017-08-03 16:30 +0200
RE: [PATCH v13 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG "Wang, Wei W" <wei.w.wang@intel.com> - 2017-08-03 17:20 +0200
Re: [PATCH v13 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG "Michael S. Tsirkin" <mst@redhat.com> - 2017-08-03 18:00 +0200
[PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-03 09:00 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-03 11:20 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-03 12:40 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-03 12:50 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-03 13:30 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-03 13:30 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-03 14:10 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-03 14:50 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-03 15:20 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-03 16:00 +0200
RE: [PATCH v13 4/5] mm: support reporting free page blocks "Wang, Wei W" <wei.w.wang@intel.com> - 2017-08-03 17:30 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks "Michael S. Tsirkin" <mst@redhat.com> - 2017-08-03 23:10 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-04 10:00 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-04 10:20 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-04 10:30 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-04 11:00 +0200
Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-08 08:20 +0200
Re: [virtio-dev] Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-08 08:40 +0200
Re: [virtio-dev] Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-10 09:10 +0200
Re: [virtio-dev] Re: [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang <wei.w.wang@intel.com> - 2017-08-10 09:40 +0200
Re: [virtio-dev] Re: [PATCH v13 4/5] mm: support reporting free page blocks Michal Hocko <mhocko@kernel.org> - 2017-08-10 10:00 +0200
csiph-web