Re: [PATCH] net: stmmac: Use the right logging function in stmmac_mdio_register

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: stmmac: Use the right logging function in stmmac_mdio_register
Date	2017-08-09 17:00 +0200
Message-ID	<ucACL-j1-7@gated-at.bofh.it> (permalink)
References	<ucAt5-fu-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 09, 2017 at 04:40:19PM +0200, Romain Perier wrote:
> @@ -285,14 +286,14 @@ int stmmac_mdio_register(struct net_device *ndev)
>  			irq_str = irq_num;
>  			break;
>  		}
> -		netdev_info(ndev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
> +		dev_info(dev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>  			    phydev->phy_id, addr, irq_str, phydev_name(phydev),
>  			    act ? " active" : "");

Hi Romain

phy_attached_print() would be better.

     Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: stmmac: Use the right logging function in stmmac_mdio_register Romain Perier <romain.perier@collabora.com> - 2017-08-09 16:50 +0200
  Re: [PATCH] net: stmmac: Use the right logging function in  stmmac_mdio_register Romain Perier <romain.perier@collabora.com> - 2017-08-09 17:00 +0200
  Re: [PATCH] net: stmmac: Use the right logging function in  stmmac_mdio_register Andrew Lunn <andrew@lunn.ch> - 2017-08-09 17:00 +0200

csiph-web